Fix route_address_set duplicated IP sets causing route creation failure - #4356
Open
ofek wants to merge 210 commits into
Open
Fix route_address_set duplicated IP sets causing route creation failure#4356ofek wants to merge 210 commits into
ofek wants to merge 210 commits into
Conversation
`SecTrustEvaluateWithError` is serial
This reverts commit 62cb06c.
nekohasekai
force-pushed
the
testing
branch
20 times, most recently
from
August 3, 2026 11:22
b2dc1fe to
115dbec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
TUN startup with
route_address_setorroute_exclude_address_setcould add every rule-set prefix twice and fail on Windows with “The object already exists”; each prefix is now added once while rule-set updates continue to work. This restores the Windows behavior fixed for issue #3725 and released in 1.12.20 through 1.12.25 after the fix did not reach the newer release line. Existing configurations require no changes.Verification
Confirmed that 1.13.14, 1.14.0-beta.2, and unmodified testing fail the same administrator-only Windows reproduction, while 1.12.21 and the equivalent literal
route_addressconfiguration start successfully. Built testing before and after the change with the Windows release tags; the patched binary started the sameroute_address_setreproduction in three clean cycles, installed one route each time, and left no adapter or route behind.