Fix Android local DNS preferred domain resolution - #4355
Merged
nekohasekai merged 1 commit intoAug 5, 2026
Merged
Conversation
nekohasekai
force-pushed
the
testing
branch
20 times, most recently
from
August 3, 2026 11:22
b2dc1fe to
115dbec
Compare
nekohasekai
force-pushed
the
testing
branch
2 times, most recently
from
August 4, 2026 14:59
8530354 to
62095fa
Compare
nekohasekai
force-pushed
the
fix/android-local-dns-preferred-domain
branch
from
August 5, 2026 06:18
2447697 to
c0c46b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
preferred_by: localsupport for the Android graphical client.The Android client replaces the regular local DNS transport with a libbox platform transport, but that transport did not implement
DNSTransportWithPreferredDomain. As a result, valid configurations failed at startup withDNS server type does not support preferred_by: local.Changes
DNSTransportWithPreferredDomainsupport to the platform transport.neighbor_domainentries before falling back to AndroidDnsResolver.Tests
Added coverage for:
neighbor_domain, and mDNS matching;neighbor_domainentries;