Skip to content

fix: dispose background notification clients - #1628

Merged
7w1 merged 2 commits into
devfrom
fix/background-client-disposal
Aug 6, 2026
Merged

fix: dispose background notification clients#1628
7w1 merged 2 commits into
devfrom
fix/background-client-disposal

Conversation

@eleboucher

@eleboucher eleboucher commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Fix background notification clients surviving disable, unmount, or a superseded effect run.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher force-pushed the fix/background-client-disposal branch from 96033b5 to 5d337bd Compare August 4, 2026 13:16
@7w1
7w1 force-pushed the fix/background-client-disposal branch from 5d337bd to 55c2db6 Compare August 6, 2026 14:10
@7w1
7w1 force-pushed the fix/background-client-disposal branch from 55c2db6 to fdd4279 Compare August 6, 2026 14:28
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

Status Preview URL Commit Alias Updated (UTC)
✅ Deployment successful! https://pr-1628-sable.raspy-dream-bb1d.workers.dev fdd4279 pr-1628 Thu, 06 Aug 2026 14:30:28 GMT

@7w1
7w1 added this pull request to the merge queue Aug 6, 2026
Merged via the queue into dev with commit 9d1e7ab Aug 6, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants