Update rubocop-rails 2.35.0 → 2.35.3 (patch)

[depfu]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.35.0 → 2.35.3) · Repo · Changelog

Release Notes

2.35.3

Bug fixes

• #1630: Fix a false positive in Rails/StrongParametersExpect when negating params[:key] with !, such as !params[:key]. (@koic)
• #1629: Fix false positives in Rails/StrongParametersExpect when using the safe navigation operator (&.) on params[:key]. Autocorrecting params[:key]&.downcase to params.expect(:key).downcase silently changes behavior — a missing param goes from returning nil to raising ActionController::ParameterMissing. (@lucasmazza)

2.35.2

Bug fixes

• #1625: Fix false positives in Rails/StrongParametersExpect when using collection methods (such as delete, keys, merge, slice, dig, fetch, or transform_values) on params[:key], as well as block-style calls such as params[:key].each { ... } or params[:key].map(&:to_s). (@koic)
• #1627: Fix false positives in Rails/StrongParametersExpect for usages like params[:key].try(:method) and params[:key].try!(:method). (@nicholasdower)

2.35.1

Bug fixes

• #1616: Fix false positives in Rails/StrongParametersExpect when using nil-safe conversion methods such as to_i, to_s, to_a, to_f, and to_h on params[:key]. (@koic)
• #1622: Fix false positives in Rails/StrongParametersExpect when using key-check methods such as key?, has_key?, include?, and member? on params[:key]. (@koic)
• #1620: Fix false positives in Rails/StrongParametersExpect when using type-check methods such as is_a?, kind_of?, and instance_of? on params[:key]. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 24 commits:

• Cut 2.35.3
• Update Changelog
• Merge pull request #1631 from koic/fix_false_positive_for_rails_strong_parameters_expect_with_negation
• [Fix #1630] Fix a false positive in `Rails/StrongParametersExpect`
• Merge pull request #1629 from lucasmazza/fix/strong-parameters-expect-safe-navigation
• Fix Rails/StrongParametersExpect to allow safe navigation operator on optional params
• Reset the docs version
• Cut 2.35.2
• Update Changelog
• Merge pull request #1626 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_collection_methods
• [Fix #1625] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1627 from nicholasdower/try
• Fix false positives for try and try! in Rails/StrongParametersExpect
• Reset the docs version
• Cut 2.35.1
• Update Changelog
• Merge pull request #1624 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_key_check_methods
• [Fix #1622] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1623 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_type_check_methods
• [Fix #1620] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1616 from koic/fix_false_positives_in_rails_strong_parameters_expect
• [Fix #1618] Update the doc of `Rails/RedundantActiveRecordAllMethod`
• Fix false positives in `Rails/StrongParametersExpect`
• Reset the docs version

✳️ rubocop (1.86.2 → 1.87.0) · Repo · Changelog

Release Notes

1.87.0

New features

• #15167: Add --enable-all-cops and --disable-all-cops command line options that override AllCops/EnabledByDefault and AllCops/DisabledByDefault in configuration files. (@koic)
• #15185: Make Layout/EmptyLineAfterGuardClause accept the new # simplecov:disable and # simplecov:enable directive comments. (@koic)
• #15173: Add optional Rubydex integration via AllCops/UseProjectIndex to enable cross-file detection in Lint/ConstantReassignment (experimental). (@koic)

Bug fixes

• #15168: Fix false positives in Lint/ParenthesesAsGroupedExpression when the first argument is a call-like expression with its own parentheses, such as yield(...). (@koic)
• #15188: Fix false positives in Style/YodaCondition when one side is an array or hash literal containing non-literal elements. (@koic)
• #15182: Fix incorrect autocorrect for Style/Alias causing a syntax error when the return value of alias_method is used, such as an argument to public, private, protected, or module_function, or the right-hand side of an assignment. (@koic)
• #15174: Fix incorrect autocorrect for Style/ClassAndModuleChildren causing a syntax error when the namespace contains a method call (e.g., class self.class::Foo; end). (@koic)
• #15180: Fix incorrect autocorrect for Style/FileWrite causing a syntax error when the written heredoc is chained with another method call. (@koic)
• #15186: Fix incorrect autocorrect for Style/HashConversion causing a syntax error when Hash[...] is passed an anonymous splat (*). (@koic)
• #15192: Fix incorrect autocorrect for Style/StructInheritance causing a syntax error when the inherited Struct.new is called without parentheses. (@koic)
• #15170: Fix an infinite loop for Layout/RedundantLineBreak when a single-line block is chained with a safe navigation method call. (@koic)
• #15175: Fix Layout/IndentationWidth to indent block bodies relative to the method selector for trailing-dot multi-line method chains when EnforcedStyleAlignWith is relative_to_receiver. (@ddbrendan)
• #15135: Fix incorrect autocorrect for Style/RedundantParentheses that swallowed chained method calls into a trailing inline comment on the line above the closing parenthesis. (@hammadxcm)
• #15184: Fix various typos and grammar mistakes in documentation and cop descriptions. (@bbatsov)

Changes

• #15171: Cache FilePatterns#match? results per path so cops sharing the same Include/Exclude configuration do not each repeat File.fnmatch? work on every file. (@Darhazer)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 29 commits:

• Cut 1.87
• Update Changelog
• Fix incorrect autocorrect for `Style/StructInheritance` cop
• [Fix #15185] Make `Layout/EmptyLineAfterGuardClause` accept new SimpleCov directives
• Merge pull request #15190 from koic/fix_false_positives_in_style_yoda_condition
• [Fix #15188] Fix false positives for `Style/YodaCondition`
• Fix incorrect autocorrect for `Style/HashConversion` cop
• Merge pull request #15184 from rubocop/fix-typos-and-grammar-in-docs
• Fix various typos and grammar mistakes in documentation
• Merge pull request #15182 from koic/fix_incorrect_autocorrect_for_style_alias_inside_visibility_modifier
• Fix incorrect autocorrect for `Style/Alias` cop
• Merge pull request #15180 from koic/fix_incorrect_autocorrect_for_style_file_write_cop
• Fix incorrect autocorrect for `Style/FileWrite` cop
• Add lazy load support to Registry
• Add `--enable-all-cops` and `--disable-all-cops` command line options
• Add optional Rubydex integration
• Merge pull request #15175 from ddbrendan/fix/multiline-block-body-indentation-after-chain
• Merge pull request #15174 from koic/fix_incorrect_autocorrect_for_style_class_and_module_children
• Fix `Layout/IndentationWidth` for trailing-dot chains under `relative_to_receiver`
• Fix incorrect autocorrect for `Style/ClassAndModuleChildren`
• Merge pull request #15140 from hammadxcm/fix/15135-redundant-parentheses-comment-swallows-chain
• Merge pull request #15171 from rubocop/cache-file-patterns-match-results
• Cache `FilePatterns#match?` results per path
• Merge pull request #15170 from koic/fix_infinite_loop_for_layout_redundant_line_break
• Fix an infinite loop for `Layout/RedundantLineBreak` cop
• Merge pull request #15169 from koic/fix_false_positives_in_lint_parentheses_as_grouped_expression
• [Fix #15168] Fix false positives in `Lint/ParenthesesAsGroupedExpression`
• Use mcp gem 0.16.0+ for development
• Reset the docs version

↗️ json (indirect, 2.19.5 → 2.19.8) · Repo · Changelog

Release Notes

2.19.8 (from changelog)

• Fix 1-byte buffer overread on EOS errors.
• Handle invalid types passed as max_nesting option.

2.19.7

What's Changed

• Fix some more edge cases with out of range floats.
• Ensure the string provided to JSON.parse can't be mutated during parsing.
• Add missing write barriers in State#dup.
• Further validate generator depth config.

Full Changelog: v2.19.6...v2.19.7

2.19.6

What's Changed

• Cleanly handle overly large depth generator argument.
• Add missing write barrier in ParserConfig.

Full Changelog: v2.19.5...v2.19.6

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:

• Release 2.19.8
• Prevent buffer over-read when generating EOF error
• Handle invalid types passed as `max_nesting` option
• Get rid of all_images gem
• Add a security note in README
• Release 2.19.7
• Fix some more edge cases with out of range floats
• parser.c: Ensure the user provided string can't be mutated
• generator.c: trigger write barriers in cState_init_copy
• Further validate generator `depth` config
• Release 2.19.6
• Add ruby-asan to CI
• generator.c: Handle stupidly large depth
• Add missing write barrier in ParserConfig

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)