Skip to content

[autobackport: sssd-2-12] Tests: Add integration tests validating SSSD socket#8564

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8481-to-sssd-2-12
Apr 10, 2026
Merged

[autobackport: sssd-2-12] Tests: Add integration tests validating SSSD socket#8564
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8481-to-sssd-2-12

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8481 Tests: Add integration tests validating SSSD socket to branch sssd-2-12, created by @aborah-sudo.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8481-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8481-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8481-to-sssd-2-12 --force

Original commits
abee6e7 - Tests: Add integration tests validating SSSD socket

Backported commits

  • 0f30329 - Tests: Add integration tests validating SSSD socket

Original Pull Request Body

Add integration tests validating SSSD socket activation behavior for individual responders and mixed socket/traditional configurations.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new suite of system tests for SSSD socket activation, covering responder lifecycles, autofs integration, mixed service configurations, and conflict handling. The review feedback correctly identifies missing assertions in several test cases where the implementation did not fully align with the docstrings' claims regarding initial service inactivity. Code suggestions were provided to ensure the service units are verified as inactive before the first request is triggered.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Apr 10, 2026
@alexey-tikhonov
Copy link
Copy Markdown
Member

Older branches won't build on newest Fedora because of libini_config changes.

Add integration tests validating SSSD socket activation behavior
for individual responders and mixed socket/traditional configurations.

Reviewed-by: Alexey Tikhonov <atikhono@redhat.com>
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
(cherry picked from commit abee6e7)
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🔴 rpm-build:fedora-rawhide-x86_64:upstream (failure)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8481-to-sssd-2-12 branch from 0f30329 to d4a7663 Compare April 10, 2026 12:29
@alexey-tikhonov alexey-tikhonov merged commit f6c8fef into SSSD:sssd-2-12 Apr 10, 2026
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants