Add method to check if a path in zipfs is a symbolic link#2219
Open
schmelter-sap wants to merge 1 commit intoSAP:sapmachinefrom
Open
Add method to check if a path in zipfs is a symbolic link#2219schmelter-sap wants to merge 1 commit intoSAP:sapmachinefrom
schmelter-sap wants to merge 1 commit intoSAP:sapmachinefrom
Conversation
Member
|
Hello @schmelter-sap, this pull request fulfills all formal requirements. |
Member
|
restest this please |
Member
|
Do you really need this SharedSecrets stuff? I think for jdk.nio.zipfs it is fine to add public methods and call them since those are internal implementation classes. You should only need to export the jdk.nio.zipfs package to jdk.sapext and then you can directly call any method you add. |
RealCLanger
reviewed
Apr 18, 2026
| * @param path The path in the zipfs. | ||
| * @return <code>true</code> if the path represents a symbolic link. | ||
| */ | ||
| public static boolean isSymbolicLink(Object path) { |
Member
There was a problem hiding this comment.
The parameter should rather be java.nio.file.Path instead of just Object, no?
RealCLanger
reviewed
Apr 18, 2026
|
|
||
| return access.isSymbolicLink(path); | ||
| } | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method to check if a given path from zipfs corresponds to a symbolic link.
fixes #2218