Fix compiling error on ROS2 rolling#1392
Merged
minggangw merged 1 commit intoRobotWebTools:developfrom Feb 12, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation error when building against ROS2 Rolling by adapting to a breaking API change in the ROS2 lifecycle state machine initialization. The ROS2 Rolling API now requires a clock parameter for rcl_lifecycle_state_machine_init, which was not present in earlier versions.
Changes:
- Added version-specific code path for ROS2 Rolling (ROS_VERSION >= 5000) that includes the new clock parameter requirement
- Updated JavaScript code to pass the node's clock handle to the native lifecycle state machine creation function
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rcl_lifecycle_bindings.cpp | Added new conditional compilation block for ROS2 Rolling that extracts clock handle from the third parameter and passes it to rcl_lifecycle_state_machine_init |
| lib/lifecycle.js | Updated createLifecycleStateMachine call to include this._clock.handle as the third parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minggangw
added a commit
that referenced
this pull request
Feb 14, 2026
This PR fixes a compilation error when building against ROS2 Rolling by adapting to a breaking API change in the ROS2 lifecycle state machine initialization. The ROS2 Rolling API now requires a clock parameter for `rcl_lifecycle_state_machine_init`, which was not present in earlier versions. **Changes:** - Added version-specific code path for ROS2 Rolling (ROS_VERSION >= 5000) that includes the new clock parameter requirement - Updated JavaScript code to pass the node's clock handle to the native lifecycle state machine creation function Fix: #1391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compilation error when building against ROS2 Rolling by adapting to a breaking API change in the ROS2 lifecycle state machine initialization. The ROS2 Rolling API now requires a clock parameter for
rcl_lifecycle_state_machine_init, which was not present in earlier versions.Changes:
Fix: #1391