Skip to content

Add MoveIt Task Constructor packages (core, capabilities, visualization, demo, rviz_marker_tools)#14

Open
iamnambiar wants to merge 10 commits into
RoboStack:mainfrom
iamnambiar:add-moveit-task-constructor-pkgs
Open

Add MoveIt Task Constructor packages (core, capabilities, visualization, demo, rviz_marker_tools)#14
iamnambiar wants to merge 10 commits into
RoboStack:mainfrom
iamnambiar:add-moveit-task-constructor-pkgs

Conversation

@iamnambiar

Copy link
Copy Markdown

This PR adds the six MoveIt Task Constructor packages to ros-lyrical:

  1. moveit-task-constructor-core
  2. moveit-task-constructor-capabilities
  3. moveit-task-constructor-msgs
  4. moveit-task-constructor-visualization
  5. moveit-task-constructor-demo
  6. rviz-marker-tools

along with patches needed to build moveit-task-constructor-core and moveit-task-constructor-visualization.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Thanks @iamnambiar! There is some issue on Windows, please take a look and let us know if you need help.

Best, Tobi

@iamnambiar

Copy link
Copy Markdown
Author

@Tobias-Fischer
From the logs, I understand that it's trying to build ros-lyrical-py-binding-tools because the packages that I have added depends on it. This package has already been built and released for Ubuntu, but not for Windows. See:

- py_binding_tools

I'm hoping this same issue came up when someone previously tried to build it for Windows. I'm happy to fix this as part of this PR by adding a patch. However, since the package has already been added, this would require incrementing the build number to generate a new recipe, which would also regenerate recipes for all the other packages. I'm not sure if that's the way to do this. Or else, I can update the vinca.yaml file to disable and skip the Windows build for now.

What do you think is the best approach here?

Updated the import statements to use 'module_' instead of 'module' for C++20 compatibility.
Updated CMakeLists.txt and header files for C++20 compatibility by renaming module and exporting functions correctly.
@Tobias-Fischer

Copy link
Copy Markdown
Contributor

I fixed the py_binding_tools issue. There are now other Windows errors, can you please have a go at fixing them @iamnambiar

@iamnambiar

Copy link
Copy Markdown
Author

@Tobias-Fischer Thank you for fixing the py_binding_tools issue. I was actually running this locally on my windows partition now and trying to fix the issues one by one.

@Tobias-Fischer

Copy link
Copy Markdown
Contributor

Cool I'll let you do, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants