Repository navigation
Fix overlay lookup in LoadBobFile test - #31
Merged
Flamefire merged 2 commits intoOct 31, 2026
Merged
Conversation
Contributor
Author
|
I used Claude Opus 5.5 to analyze why the AppVeyor check failed, and below is the result of its analysis. Conclusion is that it's not related to the changes introduced by this PR. Analysis Report (same error at lines 229 and 249)
Possible fixes, outside this PR: move AppVeyor to the VS 2022 image (or drop it, as GitHub Actions already covers MSVC), and/or pin libutil there. Alternatively, keep |
Member
|
I fixed the compat issue of span.hpp and enhanced a bit of the testing machinery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BobFiles/LoadBobFilefails 2 assertions (testBob.cpp:60/63) since 22754f4: the expected valuewraps the sprite id as
OverlayIdx{spriteId}and skips thegetOverlayData()lookup thatgetOverlay()does, so it compares against an empty archive slot.This uses
getOverlayArchiveIndex(getOverlayData(spriteId).idx), the same lookupgetOverlay()uses, which is what the test checked before via
getOverlayIdx(spriteId).CI doesn't catch it because the test needs the original S2 files (
hasS2Data).Tested with the S2 data on MSVC and gcc (74/74 test cases pass) and without it.