Conversation
Use the handler configured when an error occurs even if global configuration changes before asynchronous delivery. Fixes ReactiveX#7126 Signed-off-by: Jake Wang <jakezwang@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Capture
config.onUnhandledErrorwhen the error occurs, before scheduling its asynchronous delivery. Replacing or clearing the handler afterward should not redirect an already-reported error. If there was no handler, setting one later should not swallow that error.This follows the core team's decision in #6436 (comment). This is a small fix targeted at
7.x; the currentmasterbranch is the separate RxJS Next implementation. The broader original PR #6436 was closed in favor of a focused fix.Related issue: Fixes #7126.
Validation:
npm run lint,npm run compile,npm run dtslint, and focused Prettier check passed.Implementation and validation were performed primarily with OpenAI Codex.