Fix finish error propagation in StreamableUsing - #8312
Merged
Merged
Conversation
Signed-off-by: myetcd <mytech@139.com>
akarnokd
approved these changes
Sep 29, 2026
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.72 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8312 +/- ##
============================================
- Coverage 98.61% 98.59% -0.03%
+ Complexity 7158 7155 -3
============================================
Files 824 824
Lines 50800 50801 +1
Branches 6913 6914 +1
============================================
- Hits 50098 50088 -10
- Misses 477 481 +4
- Partials 225 232 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StreamableUsing.finish() currently completes successfully when upstream cleanup fails but the resource cleaner succeeds. If both fail, it reports only the resource cleaner failure and loses the upstream failure.
Preserve the upstream finish failure and add any resource cleaner failure as suppressed using ExceptionHelper.unwrapAndCombine. Also correct the throwIfFatal call to check the caught cleaner exception.
Add regression tests for upstream finish failure with successful and failing resource cleanup, including verification that resource cleanup still runs after upstream finish fails.
Validation: