Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

How am I supposed to import observable methods? #1553

Description

@Sawtaytoes

I'm planning on using Webpack 4 in the future and am currently on Webpack 3. I'd like to get the full benefit of tree-shaking and want to make sure I'm importing rxjs correctly in my projects.

First, Webpack 4 has a thing that restricts you to either cjs, esm, or any import format. Webpack 3 does not have this, but does utilize tree-shaking where it exists.

When I do:

import { bindCallback } from 'rxjs/observable/bindCallback'

Am I using the cjs method and tree-shaking or will this automatically use esm if available?

From using other libraries like date-fns, I believe I have to do this instead:

import { bindCallback } from 'rxjs/_esm2015/observable/bindCallback'

Is my assumption correct, or do I keep calling imports like I've always been doing (the first example)?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions