Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
📌 Code Review Assignment🏷️ Tag: workflowReviewers: Rbb666 kurisaW supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2026-02-25 17:26 CST)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new RT-Thread BSP for the XuanTie XiaoHui c908x platform, including build scripts, configuration, board init, and the corresponding low-level startup/interrupt/trap implementation in the XuanTie dummy chip library. It also registers the BSP in CI compile list.
Changes:
- Add new BSP directory
bsp/xuantie/xiaohui/c908xwith RT-Thread config, SCons build entrypoints, board init, and documentation. - Add c908x CPU support files under
bsp/xuantie/libraries/.../chip_riscv_dummy/src/arch/c908x/(startup, vectors, trap, system). - Update
.github/ALL_BSP_COMPILE.jsonto includexuantie/xiaohui/c908x.
Reviewed changes
Copilot reviewed 28 out of 32 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/xuantie/xiaohui/c908x/utilities/gdb.init | Adds GDB init script used by the BSP project/debug setup. |
| bsp/xuantie/xiaohui/c908x/template.cdkws | Adds CDK workspace template for the BSP. |
| bsp/xuantie/xiaohui/c908x/template.cdkproj | Adds CDK project template (build/debug settings). |
| bsp/xuantie/xiaohui/c908x/rtconfig_preinc.h | Adds generated pre-include configuration macros for toolchain/build. |
| bsp/xuantie/xiaohui/c908x/rtconfig.py | Adds GCC toolchain configuration and flags for c908x. |
| bsp/xuantie/xiaohui/c908x/rtconfig.h | Adds RT-Thread Kconfig-generated build configuration header. |
| bsp/xuantie/xiaohui/c908x/qemu.bat | Adds Windows helper script to run QEMU for this BSP. |
| bsp/xuantie/xiaohui/c908x/objdump.bat | Adds Windows helper script to disassemble the built ELF. |
| bsp/xuantie/xiaohui/c908x/figures/1.env.png | Adds documentation screenshot used by README. |
| bsp/xuantie/xiaohui/c908x/board/board.h | Adds board feature macros and board init API declarations. |
| bsp/xuantie/xiaohui/c908x/board/board.c | Adds rt_hw_board_init() implementation for RT-Thread startup. |
| bsp/xuantie/xiaohui/c908x/board/SConscript | Adds SCons build rules for the board layer. |
| bsp/xuantie/xiaohui/c908x/board/Kconfig | Adds BSP-specific Kconfig options (UART/FPU). |
| bsp/xuantie/xiaohui/c908x/applications/main.c | Adds sample main() entry for the BSP. |
| bsp/xuantie/xiaohui/c908x/applications/SConscript | Adds SCons build rules for applications. |
| bsp/xuantie/xiaohui/c908x/SConstruct | Adds top-level SCons build entry for the BSP. |
| bsp/xuantie/xiaohui/c908x/SConscript | Adds module compilation script to include subcomponents. |
| bsp/xuantie/xiaohui/c908x/README.md | Adds BSP documentation (features, toolchain links, QEMU run/debug). |
| bsp/xuantie/xiaohui/c908x/Kconfig | Adds BSP root Kconfig wiring into RT-Thread Kconfig tree. |
| bsp/xuantie/xiaohui/c908x/.settings/projcfg.ini | Adds RT-Thread Studio/Eclipse project settings for the BSP. |
| bsp/xuantie/xiaohui/c908x/.settings/org.eclipse.core.runtime.prefs | Adds Eclipse runtime prefs for the BSP project. |
| bsp/xuantie/xiaohui/c908x/.project | Adds Eclipse project metadata. |
| bsp/xuantie/xiaohui/c908x/.config | Adds default defconfig for the BSP. |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c908x/vectors.S | Adds interrupt/trap/handler assembly for c908x. |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c908x/trap_c.c | Adds C-side trap dump/exception handler glue. |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c908x/system.c | Adds c908x SystemInit, cache/PLIC/tick init, feature enables. |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c908x/startup.S | Adds reset/startup vectors and stack setup for c908x. |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c908x/SConscript | Registers c908x arch sources in SCons. |
| .github/ALL_BSP_COMPILE.json | Adds the BSP to CI BSP compile matrix. |
| # XuanTie - C908X Series | ||
|
|
||
| ## 一 简介 |
There was a problem hiding this comment.
[custom/自定义]: PR title prefix format does not follow RT-Thread convention
English: PR title should use a lowercase prefix like [module][subsystem] Description. Current title "Feat/xuantie c908x" doesn’t match the required bracketed prefix pattern. Suggested: [xuantie][bsp] Add xiaohui c908x BSP (or similar that matches the touched paths).
中文:PR 标题应使用小写的前缀格式:[模块][子系统] 描述。当前标题 "Feat/xuantie c908x" 不符合方括号前缀规范。建议:[xuantie][bsp] Add xiaohui c908x BSP(或其它与修改路径匹配的标题)。
| ### 1. 内核 | ||
|
|
||
| C908X 是基于RISC-V 指令架构的64 位高性能多核心处理器,主要面向市场日益增强的图像、视觉处理 | ||
| 领域,例如智慧视觉、车载视觉、行车记录仪、智能交互等。其他应用领域还包括扫地机器人、无人机、自 |
There was a problem hiding this comment.
[documentation/文档]: PR description still contains the template wrapper brackets
English: The PR description still includes the surrounding [ ... ] template wrapper text, which the template says must be replaced/removed; this typically blocks merging in RT-Thread’s PR process. Please update the PR description to remove the template wrapper and keep only the filled-in sections (What/Why/How + test/verification info).
中文:PR 描述中仍保留了模板要求替换/删除的 [ ... ] 外层包裹内容(模板提示不替换会导致无法合并)。请更新 PR 描述,移除模板包裹,仅保留已填写的 What/Why/How 以及测试/验证信息。
- fix Incorrect libraries_path_prefix when a local "./libraries" directory exists;
拉取/合并请求描述:(PR description)
为什么提交这份PR (why to submit this PR)
Support XuanTie c908x serial processors
你的解决方案是什么 (what is your solution)
Support XuanTie c908x serial processors
请提供验证的bsp和config (provide the config and bsp)
bsp/xuantie/xiaohui/c908x
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up