fix(help): recommend a resolvable model and label bare rocm as the launcher (EAI-8011) - #296
Merged
Conversation
…uncher (EAI-8011) The help's worked examples named `rocm serve qwen2.5-7b-instruct`, which is neither a catalog name nor an owner/repo reference, so copying an example verbatim fails. Use `qwen`, a real catalog alias for the built-in assistant that `rocm model` resolves. The long help also described running `rocm` with no subcommand as opening the dashboard — the same thing it says `rocm dash` does. Bare `rocm` opens the launcher; describe it as such so the two read distinctly. Signed-off-by: fredespi <fredrik.espinoza@gmail.com>
fredespi
force-pushed
the
rocm-help-recommends-a-nonexistent-model-id-and
branch
from
August 21, 2026 14:35
0294ce9 to
fbdee8b
Compare
r0x0r
reviewed
Aug 24, 2026
r0x0r
left a comment
r0x0r
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. Doc/help-text only, no behaviour change, and both fixes check out against the code:
qwenis a real, resolvable catalog alias —BUILTIN_ASSISTANT_MODEL_ALIAS = "qwen"maps toQwen3-4B-Instruct-2507-GGUF(apps/rocm/src/providers.rs), so every replacedrocm serve qwen/rocm chat --model qwenexample now names something the CLI can actually resolve, unlike the previousqwen2.5-7b-instruct.- The
long_aboutwording change is accurate: barerocmroutes tolaunch_default→run_launcher(the launcher/TUI), and the distinctdashrow still describes the dashboard, so the two no longer read identically.
All six occurrences are consistent and the EXAMPLES column realignment looks right. No substantive concerns.
r0x0r
approved these changes
Aug 24, 2026
r0x0r
left a comment
r0x0r
left a comment
Collaborator
There was a problem hiding this comment.
Approving. The two EAI-8011 help-text defects are fixed correctly: every serve/chat example now names qwen, a real resolvable alias (BUILTIN_ASSISTANT_MODEL_ALIAS -> Qwen3-4B-Instruct-2507-GGUF), and the bare-rocm long_about now accurately says launcher (launch_default -> run_launcher) while the dash row still describes the dashboard. Doc-only, no behaviour change, 24/24 CI green.
fredespi
added a commit
that referenced
this pull request
Sep 9, 2026
Brings the branch up to date with main and addresses the review findings that depend on it. Stale expectation rows deleted (their bugs are fixed on main); the scenarios stay as guards: - help-serve-example-names-a-resolvable-model, help-describes-the-default-command (#296 made the worked example 'rocm serve qwen' and relabelled bare 'rocm' the launcher) - serve-rejects-no-advertised-device-policy (#304 hid cpu_only from the advertised list) - diagnose-commands-name-a-real-group (#302 filters the UNKNOWN group lookup) Verified in a Linux container on two hosts: 0 XPASS, 0 stale. Other review fixes: - advertised_device_policies reads clap's block rendering as well as the inline one, so the scenario keeps measuring the contract instead of tripping its own guard - run_rocm_without_env deleted (no call sites) - the services-stop comment now matches its expectations.toml row - 'not the leading remedy' reworded to 'not offered as a cause', which is what the assertion checks - the non-default device group is chosen from plausible device groups rather than whichever /etc/group lists first - scenario numbers made unique and prefixed after main's renumbering - new unit test rejects an expectations.toml row whose scenario no longer exists Signed-off-by: fredespi <fredrik.espinoza@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two help-text defects surfaced by the README walkthrough (EAI-8011), fixed in
apps/rocm/src/main.rs. Help/doc text only — no behaviour change.rocm serve qwen2.5-7b-instructis neither a catalog name nor anowner/reporeference, so copying an example verbatim fails. Replaced all six help/doc occurrences withqwen, a real catalog alias for the built-in assistant (Qwen3-4B-Instruct-2507-GGUF) thatrocm modelresolves. Realigned the top-level EXAMPLES column for the shorter name.rocmas opening the dashboard — the same thing it saysrocm dashdoes. Runningrocmwith no subcommand actually opens the launcher (launch_default→run_launcher), so thelong_aboutnow says "interactive launcher (TUI)". Thedashcommand's own help row still describes the dashboard, so the two read distinctly.These are the two EAI-8011 rows pinned as expected failures in #241; once both land those rows XPASS and retire themselves.
Test plan
rocmon Linux (macOS can't build this repo — known platform-gatedst_modefailure inrocm-engine-lemonade).rocm help,rocm serve --help,rocm model --verboseagainst the built binary at wide terminal width; confirmed everyrocm serveexample namesqwen(listed inmodel --verboseasaliases=[qwen, ...]) and the no-subcommand sentence no longer says "dashboard" while thedashrow still does.