Skip to content

🌐 [translation-sync] Fix broken raw GitHub URLs for CSV data files#1

Closed
mmcky wants to merge 4 commits intomainfrom
translation-sync-2026-03-23T05-12-07-pr-491
Closed

🌐 [translation-sync] Fix broken raw GitHub URLs for CSV data files#1
mmcky wants to merge 4 commits intomainfrom
translation-sync-2026-03-23T05-12-07-pr-491

Conversation

@mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 23, 2026

Automated Translation Sync

This PR contains automated translations from QuantEcon/lecture-python-programming.

Source PR

#491 - Fix broken raw GitHub URLs for CSV data files

Files Updated

  • ✏️ lectures/pandas.md
  • ✏️ .translate/state/pandas.md.yml
  • ✏️ lectures/python_advanced_features.md
  • ✏️ .translate/state/python_advanced_features.md.yml

Details

  • Source Language: en
  • Target Language: zh-cn
  • Model: claude-sonnet-4-6

This PR was created automatically by the translation action.

@mmcky
Copy link
Contributor Author

mmcky commented Mar 23, 2026

@HumphreyYang this is a test run for integrating action-translation into an actual repo.

This zh-cn version is from an initial bulk run.

This PR appears to be changing more than the source PR, if you had time I would appreciate a review against the source PR that is linked in the above description.

Comment on lines +1 to +6
source-sha: 02e57a5befc2a9a081019edc748aba15e4b2f02a
synced-at: "2026-03-23"
model: claude-sonnet-4-6
mode: NEW
section-count: 6
tool-version: 0.11.1
mode: UPDATE
section-count: 7
tool-version: 0.11.2
Copy link
Member

@HumphreyYang HumphreyYang Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the agent has full visibility across the repository on main, so it assumes that the Advanced Features lecture has also been modified. As a result, it ends up making changes to python_advanced_features, even though that file is not part of the source PR: QuantEcon/lecture-python-programming#491

Copy link
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmcky,

I’ve also reviewed this PR.

It appears to have the same issue as #2.

The changes in pandas look great!

However, it seems the agent can see the entire repository, and as a result, it also detected changes in .translate/state/python_advanced_features.md.yml.

This is why it went into python_advanced_features and added edits from #488 - Add Type Hints section to More Language Features lecture to this PR, which was not intended.

I was wondering if we could instead have the translation agent fetch the PR page directly and apply the changes based on what’s shown there, rather than comparing the states of two repository.

I tried the following prompt locally in claude code:

"Could you please check #491 - Fix broken raw GitHub URLs for CSV data files and migrate the change to @lectures/pandas.md? Translate text to English if needed and follow the original structure."

This approach seems to work well and helps keep the agent focused on the PR itself.

Would something like this be feasible?


```{code-cell} ipython3
df = pd.read_csv('https://raw.githubusercontent.com/QuantEcon/lecture-python-programming/master/source/_static/lecture_specific/pandas/data/test_pwt.csv')
df = pd.read_csv('https://raw.githubusercontent.com/QuantEcon/lecture-python-programming/main/lectures/_static/lecture_specific/pandas/data/test_pwt.csv')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in the URL looks good.

@mmcky mmcky closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants