Skip to content

Tom's April 1 fix of logic of composite matching lecture#318

Closed
mmcky wants to merge 1 commit intomainfrom
composite
Closed

Tom's April 1 fix of logic of composite matching lecture#318
mmcky wants to merge 1 commit intomainfrom
composite

Conversation

@mmcky
Copy link
Copy Markdown
Contributor

@mmcky mmcky commented Apr 1, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 1, 2026 21:21
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for lustrous-melomakarona-3ee73e ready!

Name Link
🔨 Latest commit 9959f02
🔍 Latest deploy log https://app.netlify.com/projects/lustrous-melomakarona-3ee73e/deploys/69cd8c416ace1400085cac06
😎 Deploy Preview https://deploy-preview-318--lustrous-melomakarona-3ee73e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the algebra/logic used in the “second case of intersecting pairs” argument in match_transport.md, ensuring the strict concavity step is applied to the right convex combinations in the uncrossing proof.

Changes:

  • Replaces the prior (incorrect) definition of (\alpha) with one consistent with the ordering (x < x' < y' < y).
  • Rewrites the convex-combination equalities for (|x-y'|) and (|x'-y|) in terms of (|x-y|) and (|x'-y'|).
  • Expands the strict concavity argument into two inequalities and then adds them to obtain the desired strict improvement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

@github-actions github-actions bot temporarily deployed to pull request April 1, 2026 21:30 Inactive
@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Apr 1, 2026

I've reviewed the mathematical fix in this PR and confirm it is correct.

The original proof had two bugs:

  1. Wrong alpha formula: The original alpha = (|x-y| + |x'-y|) / (|x-y'| - |x'-y|) is not generally in (0,1). A quick check with x=0, x'=2, y'=5, y=6 gives alpha = 10, and the denominator can even be zero.

  2. Reversed convex decomposition: The original wrote |x-y| and |x'-y'| as combinations of |x-y'| and |x'-y|, but the proof needs the opposite direction -- expressing the crossed distances as combinations of the uncrossed ones -- so that strict concavity of h yields the desired inequality.

The fix is sound:

  • The new alpha = (|x-y'| - |x'-y'|) / (|x-y| - |x'-y'|) simplifies to (x'-x) / ((y-y') + (x'-x)), which is always in (0,1).
  • The convex combination identities hold and are verified algebraically.
  • Applying strict concavity of h and adding the two resulting inequalities correctly yields h(|x-y'|) + h(|x'-y|) > h(|x-y|) + h(|x'-y'|), proving uncrossing strictly reduces cost.

The presentation is also improved by breaking the final inequality chain into clear, individually justified steps.

@mmcky
Copy link
Copy Markdown
Contributor Author

mmcky commented Apr 1, 2026

thanks @thomassargent30 - I will let @HumphreyYang make the final approval and then we will merge.

@HumphreyYang
Copy link
Copy Markdown
Member

Closing in favor of #319.

@HumphreyYang HumphreyYang deleted the composite branch April 4, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants