Skip to content

fix: Read-only arrays in dwt (Issue #839) #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhossbach wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

fix: Read-only arrays in dwt (Issue #839) #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pywt/_extensions/_dwt.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cpdef dwt_coeff_len(size_t data_len, size_t filter_len, MODE mode):

return common.dwt_buffer_length(data_len, filter_len, mode)

cpdef dwt_single(cdata_t[::1] data, Wavelet wavelet, MODE mode):
cpdef dwt_single(const cdata_t[::1] data, Wavelet wavelet, MODE mode):
cdef size_t output_len = dwt_coeff_len(data.size, wavelet.dec_len, mode)
cdef np.ndarray cA, cD
cdef int retval_a, retval_d
Expand Down
6 changes: 6 additions & 0 deletions pywt/tests/test_dwt_idwt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,12 @@ def test_dwt_zero_size_axes():
assert_raises(ValueError, pywt.dwt, x, 'db2', axis=0)


def test_dwt_readonly_array():
data = np.random.randn(1000).astype(np.float64)
data.setflags(write=False)
pywt.dwt(data, "db4")


def test_pad_1d():
x = [1, 2, 3]
assert_array_equal(pywt.pad(x, (4, 6), 'periodization'),
Expand Down
6 changes: 6 additions & 0 deletions pywt/tests/test_multilevel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ def test_wavedec():
assert_(pywt.dwt_max_level(len(x), db1) == 3)


def test_wavedec_readonly_array():
data = np.random.randn(1000).astype(np.float64)
data.setflags(write=False)
pywt.wavedec(data, "db4", level=2)


def test_waverec_invalid_inputs():
# input must be list or tuple
assert_raises(ValueError, pywt.waverec, np.ones(8), 'haar')
Expand Down