fix(xpress): migrate remaining deprecated Xpress 9.8 API calls - #880
Conversation
Merging this PR will regress 2 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | test_to_lp[rolling-severity=0] |
2.1 MB | 2.9 MB | -28.17% |
| ❌ | Memory | test_to_lp[storage-n=250] |
30.7 MB | 36.3 MB | -15.54% |
| ⚡ | Memory | test_to_lp[merge_balance-severity=0] |
3.2 MB | 2.1 MB | +49.86% |
| ⚡ | Memory | test_to_lp[rolling-severity=50] |
429.7 MB | 319.5 MB | +34.51% |
| ⚡ | Memory | test_to_lp[masked-n=100] |
2.7 MB | 2 MB | +33.08% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing brunoficoxpress:fix/xpress-deprecated-api-calls (89ec178) with master (d610692)
Footnotes
-
175 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
FabianHofmann
left a comment
There was a problem hiding this comment.
thanks @brunoficoxpress
Changes proposed in this Pull Request
Several Xpress API calls used by the direct api path were still on the
lowercase API deprecated in Xpress 9.8, with no fallback to the new camelCase
names. Fixed those, and added a small test for the direct API.
Checklist
AGENTS.md).doc.doc/release_notes.rstof the upcoming release is included.