Rust API for pyinitconfig - #6173
Conversation
2f0308c to
f15f4fc
Compare
|
According to codecov almost none of the API surface is tested. Can you please make sure there's coverage for all the |
57b35c8 to
f622003
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
|
@codspeedbot fix this regression |
|
Maintainers (@ngoldbaum), is test coverage OK. Do we need a test case which deliberately causes initialization to fail so the error handling code is covered? |
c8f66ec to
99b41b0
Compare
141a505 to
7931138
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, some various thoughts and suggestions. Sorry it took a long time to get around to this one.
5ca5f0a to
5c01d67
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, this looks good to me!
|
The test case for successfully returning an error if initialization fails is failing on a few platforms as well as python 3.15. I am not sure if this is because the hack I used to make the interpreter fail doesn't fail successfully on those platforms or if there is a problem with the error reporting. |
2530e05 to
9a0494f
Compare
Adds a rust API to initialize the embedded interpreter with configuration.
Closes #6153