Fix B031 false positive for usage in mutually exclusive if/else branches#541
Open
Fridayai700 wants to merge 2 commits intoPyCQA:mainfrom
Open
Fix B031 false positive for usage in mutually exclusive if/else branches#541Fridayai700 wants to merge 2 commits intoPyCQA:mainfrom
Fridayai700 wants to merge 2 commits intoPyCQA:mainfrom
Conversation
Using the groupby generator in separate branches of an if/else is safe
since only one branch executes. Previously, B031 counted all Name
references in the loop body regardless of control flow, flagging code
like:
for _, group in itertools.groupby([]):
if condition:
list(group)
else:
list(group)
This refactors the counting to handle if/elif/else branches as mutually
exclusive, taking the maximum usage across branches rather than the sum.
Fixes PyCQA#465
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #465.
Using the
groupby()generator in separate branches of an if/else is safe since only one branch executes. Previously, B031 counted allNamereferences in the loop body regardless of control flow, so this code was incorrectly flagged:This refactors the counting logic to handle if/elif/else branches as mutually exclusive, taking the maximum usage count across branches rather than the sum. The change correctly handles: