Fix up ContainerRegistry Authentication for OCI#1949
Open
jborean93 wants to merge 1 commit intoPowerShell:masterfrom
Open
Fix up ContainerRegistry Authentication for OCI#1949jborean93 wants to merge 1 commit intoPowerShell:masterfrom
jborean93 wants to merge 1 commit intoPowerShell:masterfrom
Conversation
Updates the ContainerRegistry authentication logic to work with OCI compliant registries like `ghcr.io`. The changes skip using the Azure environment credentials unless the bearer service ends with `.azurecr.io` as these tokens are only useful for ACR. The Azure AccessToken to Bearer token exchange is also simplified with an unecessary step removed. A new special prefix is used for the username when a credential represents an Azure AccessToken. This is necessary to ensure that only these specific types of credentials will use the Azure specific steps for authentication.
jborean93
requested review from
SydneyhSmith,
adityapatwardhan,
alerickson,
anamnavi and
shammu1
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Updates the ContainerRegistry authentication logic to work with OCI compliant registries like
ghcr.io. The changes skip using the Azure environment credentials unless the bearer service ends with.azurecr.ioas these tokens are only useful for ACR. The Azure AccessToken to Bearer token exchange is also simplified with an unecessary step removed.A new special prefix is used for the username when a credential represents an Azure AccessToken. This is necessary to ensure that only these specific types of credentials will use the Azure specific steps for authentication.
While this new prefix is technically a breaking change, it isn't documented and seems like it's mostly added for testing. With the new change it is now possible to use a credential that contains the Azure app client id and client secret which was not possible before. I'm happy to talk through this more but it is important that this is fixed before too many people rely on the existing behaviour.
PR Context
Fixes: #1946
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.