Publish-PSResource: honor ExternalModuleDependencies from PrivateData.PSData during dependency validation#1948
Open
PrzemyslawKlys wants to merge 1 commit intoPowerShell:masterfrom
Open
Conversation
…ependency checks - Read ExternalModuleDependencies from both top-level metadata and PrivateData.PSData - Normalize dependency lookup to case-insensitive hashtable keys - Add publish regression test for module manifests with external dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Publish-PSResourcedependency validation soExternalModuleDependenciesare respected for module manifests when declared underPrivateData.PSData.Problem
Publish-PSResourceexcluded external dependencies only whenExternalModuleDependencieswas present at the top level of parsed metadata.For module manifests, this value is typically stored under
PrivateData.PSData.ExternalModuleDependencies, so the dependency check could still fail and incorrectly require-SkipDependenciesCheck.Root Cause
ParseRequiredModules()only looked at:parsedMetadataHash["ExternalModuleDependencies"]and did not also inspect:
parsedMetadataHash["PrivateData"]["PSData"]["ExternalModuleDependencies"]Also, dependency key matching was case-sensitive.
Changes
ParseRequiredModules()insrc/code/PublishHelper.csto:PrivateData.PSDatatest/PublishPSResourceTests/PublishPSResource.Tests.ps1Publish a module with ExternalModuleDependencies that are not publishedValidation