Tidy wizard env vars: WIZARD_ prefix, ignore in prod builds#603
Open
gewenyu99 wants to merge 2 commits into
Open
Tidy wizard env vars: WIZARD_ prefix, ignore in prod builds#603gewenyu99 wants to merge 2 commits into
gewenyu99 wants to merge 2 commits into
Conversation
Replace the greedy yargs .env('POSTHOG_WIZARD') prefix with explicit per-option WIZARD_* defaults, gated to dev/CI builds. The bare prefix would have claimed the whole WIZARD_* namespace under strictOptions and rejected unrelated vars (the build's own WIZARD_BUILD_NODE_ENV, the workbench's WIZARD_PATH/REF/...), breaking parsing; explicit wiring reads only the names we declare.
Rename POSTHOG_WIZARD_* -> WIZARD_* and consolidate the duplicate API-key path (POSTHOG_PERSONAL_API_KEY) into WIZARD_API_KEY. All these vars are ignored in published builds (IS_PRODUCTION_BUILD); end users drive the CLI through flags. Drop the dead POSTHOG_API_KEY allowlist entry and null it in the agent/MCP subprocess env so a stray shell key can't reach them. Update README, tests, and smoke-test CI.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # README.md # src/commands/basic-integration/index.ts # src/lib/runners/run-wizard.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Test plan