fix: install skills without curl/unzip for Windows compatibility#599
Open
gewenyu99 wants to merge 1 commit into
Open
fix: install skills without curl/unzip for Windows compatibility#599gewenyu99 wants to merge 1 commit into
gewenyu99 wants to merge 1 commit into
Conversation
downloadSkill shelled out to `curl` and `unzip`. `unzip` is not available on Windows, so skill installation failed there even after #417 fixed the temp-file path. Download the zip in-memory via axios and extract it in-process with fflate, guarding against zip-slip. Removes the temp file entirely (no skillTmpPath) and makes downloadSkill async. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧙 Wizard CIRun the Wizard CI and test your changes against wizard-workbench example apps by replying with a GitHub comment using one of the following commands: Test all apps:
Test all apps in a directory:
Test an individual app:
Show more apps
Results will be posted here when complete. |
sarahxsanders
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skill installation does not work on Windows.
downloadSkillshells out to two external binaries:Windows ships
curl.exe, but it has nounzipbinary, so extraction throws and the skill never lands.This is the same Windows breakage discussed on #410 (Matt's review). #417 fixed where the temp zip is written (
os.tmpdir()instead of a hardcoded/tmp), but that only addressed the path — theunzipcall one line later still fails on Windows, so skills still don't install there.Changes
Drop both external-binary dependencies in
downloadSkill(src/lib/wizard-tools.ts):axios(already a dependency, used inapi.ts/posthog-doctor) instead ofcurl.fflate(pure-JS, no native deps) via a newextractZipTohelper, with a zip-slip guard that rejects archive entries escaping the destination before any write.skillTmpPathfrompaths.ts. This also moots the temp-file collision/cleanup concern raised on feat: messages to the heavens #410.downloadSkillis nowasync; updated all three call sites (installSkillById, theinstall_skillMCP handler, andHealthCheckScreen).Net effect: one 8KB pure-JS dependency added, two process spawns (
curl+unzip) removed.Test plan
wizard-tools.test.tsforextractZipTo: nested-file extraction and zip-slip rejection.pnpm build,pnpm typecheck, andpnpm lintpass (0 errors).wizard-toolssuite green (20 tests).