Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9723 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 8 +4
Lines 76 135 +59
Branches 2 1 -1
=========================================
+ Hits 76 135 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…bility - Count sstb_self_employment_income in earned income, floored at zero per source - Require a positive heating expense for subsidized-housing households with heat in rent (plan section 2.3); market-rate renters stay eligible - State plainly that an unspecified single-family fuel is paid $0 - Add tests for SSTB income, subsidized heat-in-rent households, proration with TANF and the refugee/asylee household-size exclusion; send heating_type explicitly in every eligibility or payment case Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Program ReviewPR #9723: Nebraska LIHEAP regular heating assistance (@hua7450), head Result: 0 critical, 6 should address, 14 suggestions.
Source Documents
Branch StatusThe PR branch is 10 commits behind
Critical (Must Fix)None.
Should Address
Suggestions
PDF Audit Summary
Derived checks:
Page-reference check:
Validation Summary
Review Severity: REQUEST_CHANGESThere are 0 critical issues and 6 should-address items. APPROVE requires 0 critical and 0 should-address. Next Steps
|
DTrim99
left a comment
There was a problem hiding this comment.
Requesting changes per the program review above (#9723 (comment)): 0 critical, 6 should-address items, 14 suggestions. All 39 audited parameter values match the FY2026 sources. Run /fix-pr 9723 or address the should-address list.
…nt sourcing and boundary tests - Cite the ACF copy of the FY2026 state plan instead of the DHHS URL that now serves the FFY2027 plan - Cite the edition-pinned 475 NAC chapter 3 and 476 NAC chapters 1 and 2 PDFs instead of the live viewer - Quote both plan section 2.3 sentences and cite 476 NAC 3-002.02 and plan sections 1.1 and 9.1 for market-rate heat-in-rent renters - Add a single-family heat-in-rent payment case and a seven-person case that pins the six-person payment cap - Rename the local heating-bill flag, drop two redundant guards, note the size-6+ footnote wording, re-word two descriptions - Fix test headers, case names and inert inputs; make Case 30 depend on the earned-income disregard - Shorten the registry note Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Thanks, @DTrim99. Pushed 39cd987 plus a merge of main (head dec8b6d):
Replies:
|
Program Review — Round 2PR #9723: Nebraska LIHEAP regular heating assistance (@hua7450). Round 1 reviewed head Result: 0 critical, 2 should address remaining, 7 suggestions.
Status of round-1 should-address items
Verification of claimed suggestion fixes
Delta regression check
Critical (Must Fix)None. Should Address (remaining)
Suggestions
CI
Review Severity: REQUEST_CHANGESThere are 0 critical issues and 2 remaining should-address items (round-1 items 1 and 6). Items 2-5 are fixed, and the dwelling-default and economic-vulnerability parts of item 6 are accepted as rationale. APPROVE requires 0 critical and 0 remaining should-address items. Next Steps
|
DTrim99
left a comment
There was a problem hiding this comment.
Round 2 (#9723 (comment)): 4 of 6 round-1 should items fixed (plan link, pinned 475 NAC citations, heat-in-rent sourcing, size-cap test). Remaining: update the axiom line to queued with rulespec-us#1464 (and make that issue dispatch-ready), and track the heating_type default follow-up in the PR body or code docs. No value regressions; the new size-7 boundary test matches Guidance p. 2.
Give every multi-page reference a single page in the link, with the pages named beside it. Cite 476 NAC 3-002.02 through the pinned chapter PDF and the 2025 poverty guideline notice directly. Move the earned income sources into a list parameter, inline the YAML anchors in the integration test, note that later years carry the FY2026 amounts forward, and place Nebraska alphabetically in the registry. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Thanks for the second round. Fixes are in Should-address
Suggestions
|
Program Review — Round 3PR #9723: Nebraska LIHEAP regular heating assistance (@hua7450). Round 2 reviewed head Result: 0 critical, 1 should address remaining, 2 suggestions.
Status of round-2 should-address items
Verification of claimed suggestion fixes
Delta regression check
Critical (Must Fix)None. Should Address (remaining)
Suggestions
CIHead
Review Severity: REQUEST_CHANGESThere are 0 critical issues and 1 remaining should-address item: rulespec-us#1464 must be dispatch-ready to back the Next Steps
|
DTrim99
left a comment
There was a problem hiding this comment.
Round 3 (#9723 (comment)): the heating-default follow-up is now tracked and no value regressions were found. One item remains: rulespec-us#1464 is labelled pe-parity but not yet dispatch-ready (no PR link, module path, provision citations, verbatim law, outputs or companion tests), which the CLAUDE.md axiom-parity rule requires for a queued line. The ssa-usda CI failure is a runner kill unrelated to this PR's files; re-run triggered.
…into ne-liheap # Conflicts: # policyengine_us/programs.yaml
|
Thanks for round 3. Head is now Should-address 1, rulespec-us#1464. Filled in on 2026-10-02. The issue now has the PR link, scope and policy period; eight proposed module paths, each mapped to its corpus citation path or marked for ingest (the plan and the guidance document are in the corpus; 476 NAC chapters 1 to 3 are not, and 475 NAC chapter 3 is there only as the renumbered July 2026 edition); the regulation, plan and guidance text quoted verbatim, including the full heating payment table and the size 6 or more footnote; a required-outputs table; eleven companion cases derived by hand from the guidance tables, including the size 7 propane boundaries ($30,205 / $30,205.01 / $43,150 / $43,150.01 / $56,095 / $56,095.01) and the one-person limit at $23,475 and $23,476; and the interpretations (market-rate heat in rent, the footnote's "gross countable income" wording, self-employment, student earnings). Suggestion 1. Reworded in the PR body: totals stay at $0 until both a heating type and a fuel bill are in the microdata, and #9754 covers the heating type only. Suggestion 2. Left as is for now. Tests were not run locally; CI runs them. |
Adds partial FY2026 regular heating assistance for Nebraska. The annual result represents the heating season ending in the modeled year. For example, a single-person household with $18,000 in wages and a gas heating bill passes the $23,475 gross-income limit, then receives a $550 single-family payment after the 20% earned-income disregard.
Merged shared FPG helper PR #9731 is now included from main. This state calls that helper for lagged guidelines; rates, household-size caps, and rounding remain in state code. The helper and Massachusetts refactor are no longer part of this PR’s diff.
Year convention: undated formulas follow the model’s existing parameter backfilling, consistent with Kansas. Earlier years use the earliest available state schedule with period-specific federal guidelines and the state’s guideline lag where applicable; these are unverified historical estimates. The registry records
verified_years: "2026"; backfilling does not extend verified coverage. Dated formulas are reserved for sourced policy changes.sstb_self_employment_incomeandfarm_operations_income, is counted without another business-expense deduction; each earned source is floored at zero. Adds only the authorized state-specificne_liheap_dwelling_typeinput.SINGLE_FAMILYandMULTI_FAMILYfollow 476 NAC 1-004.16 and 1-004.11; multifamily includes apartments with separate bills and communal arrangements with shared bills. If dwelling type is omitted, the model retains its single-family fallback, so callers should report the actual type. Registers the state as partial. No federal benefit aggregate is changed.Household and immigration basis
476 NAC 1-004.09 defines the household by shared residential energy purchasing; the SPM unit approximates that economic unit. Under 476 NAC 2-002.02, a member failing the incorporated citizenship/residency requirements “must be excluded from a household.” Section 2-002.01 separately incorporates SNAP income treatment. 476 NAC chapter 1 (12-26-2020), pages 1–2 and chapter 2 (06-26-2022), page 1
This state's SNAP cross-reference is explicit. Nebraska DHHS's OBBBA FAQ, Q12, says LIHEAP “follows the SNAP rules regarding citizenship eligibility, per 476 NAC 2.002.02.” The model therefore retains the SNAP immigration-status variable, including its FY2026 exclusion of refugee/asylee status alone; it does not apply SNAP work or student eligibility tests. Since the merge of main, the shared variable also applies the SNAP qualified-alien waiting period and its exceptions; COFA status and case-specific recertification timing remain limitations, not verified eligibility determinations. DHHS OBBBA FAQ, Q12, page 3
475 NAC 3-002.06(A) states: “The pro rata share is calculated by dividing the countable income evenly among the household members, including the ineligible member.” Subsection (B) excludes that member from benefit/income-test size. The model retains eligible members' income in full and counts each excluded member's income times eligible size / total size. This applies to both earnings and unearned income; unit-level receipts lack a payer-level allocation. 475 NAC chapter 3, section 002.06(A)–(B), text in effect for FY2026, pages 47–48
Economic-vulnerability modeling assumption: Economic vulnerability under 476 NAC 1-004.06 and 2-002(A) is assumed for all households rather than separately verified. Heating responsibility is satisfied by positive heating expenses, or by heat included in rent for households outside subsidized housing. Therefore, an otherwise eligible market-rate renter with
heat_expense_included_in_rent: trueandheating_expense: 0receives the scheduled benefit. For example, a one-person multifamily household with $18,000 of wages receives $300 after the earned-income disregard. A household in subsidized housing (receives_housing_assistanceoris_in_public_housing) needs a positive heating expense, because FY2026 plan Section 2.3 (page 9) conditions those renters on being responsible for part of the heating; with heat in rent and no separate heating cost it is ineligible. Section 2.3 also says renters with utilities included in the rent must be responsible for a portion of the heating; the model treats market-rate heat-in-rent renters as responsible, resting on 476 NAC 3-002.02 (12-26-2020), page 1, which lets DHHS pay a household directly only if utilities are included in rent, and on plan sections 1.1 (page 5) and 9.1 (page 25), which list such households among those paid directly. The income test still applies; a household reporting neither heating expenses nor heat in rent remains ineligible. The market-rate treatment is a modeling assumption, not a claim that Nebraska waives its legal vulnerability requirement. No new input or actual-expense cap is added. The legal household definition includes energy paid through rent.Other limitations: Corn shares the natural-gas/electricity/coal payment column, as documented in code; no separate schedule or fuel input is added. The existing fuel enum cannot distinguish corn within
OTHER, so unsupported/unspecified single-family fuel values still return zero, including for an eligible heat-in-rent renter who reports neither fuel nor dwelling type; no fallback fuel is assumed. Multifamily uses the published all-fuel column. Code comments also record the SPM-unit and annual-income approximations, detailed immigration and disqualification gaps, business-record deduction alternatives, special farm-loss offsets requiring gross-receipts and tax-return evidence, and unverified discretionary heating supplements. These are coverage gaps, not new legal eligibility restrictions.Heating only. Cooling, crisis assistance, weatherization, and equipment assistance are excluded.
Sources (original official publications):
Validation: 77 Nebraska YAML cases cover every modeled payment cell, dwelling and fuel treatment, income boundaries, the six-person band cap, household proration, farm and business income, historical backfilling, and mixed-state calculations. The first review-fix commit (
39cd98794a) repointed the state-plan and 475/476 NAC citations to edition-pinned copies, quoted both section 2.3 sentences, and added the market-rate heat-in-rent and seven-person boundary cases. The second gives every multi-page reference a single page in the link with the pages named beside it, cites 476 NAC 3-002.02 and the 2025 poverty guideline notice directly, inlines the YAML anchors in the integration file, moves the earned income sources into a list parameter, notes that later years carry the FY2026 amounts forward, and places Nebraska alphabetically in the registry; it changes no value or formula. CI validates the current head.Microsimulation: the datasets carry no heating type and no fuel bills, and eligibility needs a heating bill, so population totals are $0 until both are in the microdata. The default heating type is tracked separately in #9754; callers must send
heating_typewith the matching fuel bill.axiom: TheAxiomFoundation/rulespec-us#1464 queued