Belgium: row-level source links, and the EU-SILC basis of the EUROMOD claims - #117
Merged
Conversation
… claims The source link only rendered inside the expanded row detail as a small "source" anchor — invisible unless a reader opened the row and hunted. The claim title in the table is now the link itself (external, with an arrow affordance; row expansion untouched via stopPropagation). EUROMOD copy care: readers assume EUROMOD means SILC — and here it does, so the surface copy now says it instead of burying it in row conditions. The description, empty state and headline all state that the JRC EUROMOD-BE claims are EUROMOD totals simulated on uprated EU-SILC survey input, not administrative statistics. Pinned by test. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes from Max's review of the live page after #116:
"still no link to the source" — the link existed but only inside the expanded row detail as a small "source" anchor. The claim title in the table is now the link itself (underlined, opens in a new tab, ↗ affordance; clicking it doesn't toggle expansion). Applies to every row with a
url— the two Belgian official rows and the JRC rows today, plus the 281 US/UK rows that already carried URLs."careful with euromod — people assume that's silc" — the assumption is correct here, so the copy now says it at the surface instead of burying it in row conditions: the JRC EUROMOD-BE claims are EUROMOD J1.0+ totals simulated on uprated EU-SILC 2022 survey input (income year 2021, private households), not administrative statistics. Stated in the reform-validation description, the comparison empty state and the headline; pinned by a new test (
EU-SILC+not administrative statisticsmust appear). Basis facts read frombe/ingest_jrc_country_report.py's vendored source pins (Table 3.1 p. 97, BE_2022_c1).App-only diff (copy + one table cell). oxlint, 19 bun tests, vite build green. Shipping on CI green per the #85 precedent.
🤖 Generated with Claude Code