Skip to content

Port household builder fixes onto main#977

Merged
anth-volk merged 44 commits into
mainfrom
fix/household-followups-main-port
May 5, 2026
Merged

Port household builder fixes onto main#977
anth-volk merged 44 commits into
mainfrom
fix/household-followups-main-port

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk commented Apr 17, 2026

Fixes #976

Summary

  • port the household-builder editing flow improvements onto main
  • preserve the selected-variable builder behavior while keeping newer builder helpers from main
  • carry over the report-builder modal naming, validation, and dropdown usability fixes

Included changes

  • use the report year from the report builder when creating/editing household drafts
  • debounce validation while editing and re-check on submit
  • commit text and numeric builder inputs on blur / Enter
  • normalize metadata-driven input formatting for builder fields
  • remove empty group entities when a person is removed from the draft
  • keep unnamed household creation behind a warning dialog
  • fall back to Household #id labels where appropriate
  • keep the custom-variable dropdown usable inside the modal

Verification

  • bun run typecheck in app

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
policyengine-app-v2 Ready Ready Preview, Comment May 5, 2026 5:14pm
policyengine-calculator Ready Ready Preview, Comment May 5, 2026 5:14pm
policyengine-calculator-next Ready Ready Preview, Comment May 5, 2026 5:14pm
policyengine-website Ready Ready Preview, Comment May 5, 2026 5:14pm

Request Review

@vercel vercel Bot temporarily deployed to Preview – policyengine-calculator-next April 17, 2026 16:42 Inactive
@vercel vercel Bot temporarily deployed to Preview – policyengine-calculator-next April 17, 2026 18:24 Inactive
@vercel vercel Bot temporarily deployed to Preview – policyengine-calculator-next April 17, 2026 22:12 Inactive
@vercel vercel Bot temporarily deployed to Preview – policyengine-calculator-next April 17, 2026 22:24 Inactive
anth-volk added 30 commits April 25, 2026 00:54
@anth-volk
Refine ingredient modal naming behavior
03aec90
@anth-volk
Guard household validation for undefined groups
0e2fbcd
@anth-volk
Make household validation app-country driven
9bbc17b
@anth-volk
Fix household validation type narrowing
44d7108
@anth-volk
Fix report-builder population viewer flow
f88389a
@anth-volk
Unify policy editor flow
31ecddb
@anth-volk
Regenerate v2 household system ids
4a0a9c0
@anth-volk
Align standalone household builder naming flow
71171d8
@anth-volk
Pass user id to v2 household association updates
385695c
@anth-volk
Fix report edit modal routing
3609f7c
@anth-volk
Share calculator providers across country routes
41b62d6
@anth-volk
Restore report config route and preserve metadata
8fe7240
@anth-volk
Fix household shadow test expectations
b475ddf
@anth-volk
Consolidate household builder on Household model
6b92c30
@anth-volk
Consolidate household model usage
37d734d
@anth-volk
Move household helpers onto model
5233777
@anth-volk
Separate household calculation output types
a5e8ee4
@anth-volk
Unify report household serialization
be810f4
@anth-volk
Move household follow-up logic onto model
a94fcfc
@anth-volk
Use migration-aware regions in user hooks
b047457
@anth-volk
Restore policy parameter change controls
299f67a
@anth-volk
Enforce country-specific household groups
9c87740
@anth-volk
Move household variable extraction onto model
b77c9b6
@anth-volk
Move household utilities onto model
f4ee452
@anth-volk
Consolidate household utility helpers
b50ba08
@anth-volk
Prompt for save-as-new ingredient names
0b9f42d
@anth-volk
Fix policy association update shadowing
a2d6bf4
@anth-volk
Resolve builder updates through association lookups
6cc88db
@anth-volk
Fix household and rename modal tests
c156fce
@anth-volk
Apply app formatting
a5791c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port household builder fixes onto main

1 participant

@anth-volk