You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A lot of times when I'm comparing gear or pasting items from trade the stats look PERFECT until I slot it and realize "oh that item was giving me strength that I needed" and I have to start my search all over and manually add the attribute in the search or switch gear around yada yada. This PR will show the required stat during comparisons. If you're over the required stat value and add more or removing the node/item doesn't put you below the requirement, it will not show in the tooltip.
I'd like to update the trader weights or at least add the ability to include the required attributes as a trader weight as well, but I haven't thought that one through and I'm not sure how much people want it anyways.
Peechey
changed the title
Add support for showing Required Stats in comparison tooltips
Add support for showing Required Attributes in comparison tooltips
Apr 24, 2026
Didn't see #6413 until posting this, I could remove the m_max I'm doing in the diff and show the "overcapped" attributes, though it would be displayed like "-x Intelligence Required" in Positive Color without additional changes. I'd probably try to use a different label.
Although... they kind of want it in the sidebar and that isn't the same as what this PR applies 🤷
FYI, two branches on my fork around the same ideas :
feature/compare-requirement-warnings: same problem as yours, different approach. A Req{Attr}FailList from CalcPerform + a helper rendering one red line per failing item/gem (e.g. Scorching Ray requires 155 Intelligence).
@mcagnion Ahh didn't know you already had a solution going! Didn't see any PRs open for it. If you've got the trade updates figured out too, by all means.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
A lot of times when I'm comparing gear or pasting items from trade the stats look PERFECT until I slot it and realize "oh that item was giving me strength that I needed" and I have to start my search all over and manually add the attribute in the search or switch gear around yada yada. This PR will show the required stat during comparisons. If you're over the required stat value and add more or removing the node/item doesn't put you below the requirement, it will not show in the tooltip.
I'd like to update the trader weights or at least add the ability to include the required attributes as a trader weight as well, but I haven't thought that one through and I'm not sure how much people want it anyways.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
Scorching Ray 155 Int Required
