Add functionality for multiple notes

[michelrtm]

Fixes #8948 .

Description of the problem being solved:

The original ticket was requesting the ability to have multiple notes both for POE 1 and 2. I have had a look at the codebase and had a stab at implementing this feature request.

Instead of 1 global notes section, this PR introduces the ability to have multiple notes for a build and allows you to create, delete, reorder and set which note is active for the build, keeping the formatting of the editor.

Steps taken to verify a working solution:

1. Created a new build and opened the Notes section
2. Edited the Default note, saved, exited and reopened the build to verify that the changes were saved
3. Added a new note to the build, , saved, exited and reopened the build to verify that the changes were saved
4. Changed the active note, , saved, exited and reopened the build to verify that the changes were saved
5. Reordered the notes list, saved, exited and reopened the build to verify that the changes were saved
6. Deleted, reordered and changed notes, exited the build and discarded changes to verify no changes were saved
7. Opened a pre-existing build with notes to ensure the notes section wasn't lost
8. Saved changes to an imported build to make sure the notes were converted to the "new" format

Link to a build that showcases this PR:

1. Validate the changes introduced by this PR in an empty build
2. Used a content creator build (Crouching_Tuna) for importing a "legacy notes" build obtained from this Youtube Video
   https://maxroll.gg/poe/pob/a13ev0o0

Before screenshot:

After screenshot:

This is the new XML structure when the build is saved:

(...)
	<Notes>
		<Note id="3" title="This is renamed note reordered">
			(...)
		</Note>
		<Note id="1" active="1">
            (... Crouching_Tuna build redacted for brevity ...)
		</Note>
		<Note id="2" title="This is a new note">
			(...)
		</Note>
	</Notes>
(...)

[michelrtm]

As far as I could tell this could be a drop-in implementation in POB for POE2 as well.

[Nightblade]

Seems like a lot of note space is wasted by the new list box. Might be better if it was next to the colour buttons, and a lot shorter?

[michelrtm]

Thanks for your comment! I've rearranged the Notes layout and moved the list to the topleft.

[majochem]

This looks pretty neat and I like it from a user perspective, but iirc there was some hesitation with expanding the notes section functionality in the past because it can already kinda bloat the exports, which puts additional strain on the hosting providers.

Did you also implement a limit for the number of additional notes sections a user can create?

[michelrtm]

@majochem thanks for the positive feedback. I understand the concerns here but wasn't aware of the hesitations.

Currently there's no limit to the number of notes to create but I'm assuming (maybe wrongly) that if the users can create multiple set of notes then they can split the bigger notes into smaller sections and this will only consume some additional characters in the XML for similar amounts of actual text in favor of improved UI/UX.

[LocalIdentity]

This looks pretty great. Think the only thing left to add would be a way to hook the notes into the loadouts so that you could show specific notes based on it. It was the first question I got when I showed it to some large creators that use the notes a bunch

[michelrtm]

Was finally able to get back to this, sorry for the delay.

I was able to link it to the Loadout system and tested creating, modifying and changing loadouts and if there is a note with the name of the loadout it will automatically change the active note to match it.

[mcagnion]

Editing a note and then creating a new note or selecting a loadout silently loses the edit. This call replaces the editor buffer before the previous note's content is copied back; the next save only updates the destination note, and reopening restores the previous text. A focused base/head load → switch → save → reload reproduction confirmed the loss.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.

[mcagnion]

Existing builds with an empty <Notes> section cannot be saved. The XML parser produces an empty Notes node; this reset leaves activeNoteId at 0 with no notes[0], and opening Notes or saving the build raises a Lua error. The historical base fixture OccVortex.xml exercises this valid shape, and a parser/load/save comparison passed on the base and failed on this head.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.

[mcagnion]

Deleting a note is not retained through the normal save flow. This callback removes the note but never marks notesTab.modFlag; with no other changes, the subsequent Notes draw keeps it false, Save remains disabled, and leaving the build skips the save prompt. Reopening restores the deleted note.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.

[mcagnion]

With multiple notes, loadout selection fails in two existing cases. A plain loadout without an exact note title produces nil, and the guard below returns before the tree, items, skills, config, or visible selector changes. A brace-linked loadout such as Leveling {A} instead reaches findSetId, but noteListSpecialLinks is never initialized, so the resolver raises a Lua error before any update. Both paths were reproduced with the exact resolver captured from this head.

AI-assisted review disclosure: This finding was identified during a review using OpenAI Codex and confirmed with a focused reproduction.