Fix build limit message being sent when it shouldn't be#13971
Open
Warriorrrr wants to merge 1 commit into
Open
Fix build limit message being sent when it shouldn't be#13971Warriorrrr wants to merge 1 commit into
Warriorrrr wants to merge 1 commit into
Conversation
Contributor
|
Seems fair can you just mention MC-308669 or the other related bug? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13941
As far as I can tell this line being there doesn't make a lot of sense and is likely a leftover, see #13941 (comment) for mcsrc links for comparing.
Before, this line was an else for a statement that checked the height, but after the changes in that snapshot it's now an else for the
this.awaitingPositionFromClient == null && level.mayInteract(this.player, pos)check, which is wrong since neither of those have anything to do with reaching max height.