Add Block#isFluidReplaceable#13950
Conversation
|
canBeReplaced(Fluid) is just equivalent to state.canBeReplaced() || !state.isSolid() with two exceptions for end blocks. So i'm not sure this is really needed, the fluid parameter is not even used currently. |
I would argue for intuitiveness this is still a good addition, no developer that doesn't check or already know the NMS logic is going to intuitively know/guess that a block can be replaced by fluids only if either block.isReplaceable() or !block.isSolid(), and if Minecraft ever does add blocks with more complex behavior (such as using the fluid parameter) then it would be automatically handled. |
We have Block#isReplaceable but we don't have any way of checking if its replaceable with a fluid, this just exposes that as well.