docs: fix stale references in resolver and parser comments and the prqlc-c README - #6405
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three references that point at things that no longer exist. Comments and docs only; no code changes.
prqlc/bindings/prqlc-c/README.md. The README said the Zig example uses@cImport. Since ci: update minimal-zig example to the Zig 0.17 build API #6402 it translatesprqlc.hwithb.addTranslateCinbuild.zig, andsrc/main.zigdoes@import("prqlc").Resolver::in_func_call_name(semantic/resolver/mod.rs). The doc comment linked[test::test_func_call_resolve], which doesn't exist anywhere in the workspace. It now says what the flag does:resolver/expr.rssets it while folding a call's name, so a function decl is returned as-is instead of going throughfold_expr.prqlc-parser/src/parser/pr/expr.rs. A comment said the code below it "is tested by the tests_misc crate to match expr.rs in prqlc". Notests_misccrate exists any more, so the comment is removed.These came from the nightly review of recent commits (#6402) and the rolling file survey. No test applies, and they don't need a changelog entry.