fix comparator for std::sort, follow strict weak ordering#112
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the closure-candidate sorting logic in MapClosures::GetTopKClosures to ensure the std::sort comparator satisfies strict weak ordering, preventing undefined behavior during sorting.
Changes:
- Replace
>=with>in the closure-candidate comparator used bystd::sort.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important change to the sorting logic for closure candidates in the
MapClosures::GetTopKClosuresfunction. The comparison now uses strict greater-than (>) instead of greater-than-or-equal-to (>=), which ensures that closure candidates with the same number of inliers are not treated as interchangeable in the sort order. This avoids weird, once in a million issue with std::sort that core dumps life.