Repository navigation
Authenticate coverage uploads with GitHub OIDC - #27
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
- Coverage 96.58% 96.32% -0.26%
==========================================
Files 107 108 +1
Lines 8311 8080 -231
==========================================
- Hits 8027 7783 -244
- Misses 284 297 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codecov rejects unauthenticated coverage uploads from protected branches, but the CI jobs still pass because upload errors are non-fatal.
Use GitHub OIDC to authenticate coverage uploads on macOS and Ubuntu. Limit the new permission to those jobs and fail CI when a coverage upload fails.
Validation:
actionlintpasses for both workflows, andgit diff --checkpasses.e34d96a.codecov/patchpasses.codecov/projectreports 96.32% against the old 96.58% baseline atd81fffe, which is four commits behindmain. This PR changes only the two workflows; the current main branch needs a fresh coverage report.