Feature/better logs page#206
Conversation
Deploying openshockapp with
|
| Latest commit: |
7f79d8d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c08108c1.openshockapp.pages.dev |
| Branch Preview URL: | https://feature-better-logs-page.openshockapp.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cb4d08180
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .then((res) => { | ||
| logs = res.items; | ||
| page = res.page; | ||
| total = res.totalCount; | ||
| }) |
There was a problem hiding this comment.
When the table height is measured or the user changes filters/sorting/page while a previous shockerGetAllShockerLogs call is still in flight, both requests can resolve out of order and this handler unconditionally overwrites logs, page, and total with whichever response finishes last. In that scenario the UI can show all-shocker or old-page results while the current controls and URL indicate a different filter/page; add a request token/cancellation guard before applying the response.
Useful? React with 👍 / 👎.
1 participant
No description provided.