fix: .changes release scripts#473
Closed
hhvrc wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release tooling around .changes/ to enrich release metadata (PR + author attribution), generate reusable markdown release notes, and tighten CI validation/feedback for change files.
Changes:
- Extend
scripts/release.pyto (optionally) derive PR number + author viagh api, emit them intorelease.json, and render attribution + a Contributors section in generated markdown. - Generate
release-notes.mdduringrc/stableand update the release workflow to publish GitHub Releases using--notes-file. - Enhance
check-changesto expose detected change files as outputs, rejectpr:overrides in PR-authored change files, and upsert a PR status comment.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/release.py |
Adds author support, derives PR+author info, renders attribution/contributors, and writes release-notes.md. |
.github/workflows/release.yml |
Switches GitHub Release creation to use --notes-file release-notes.md. |
.github/workflows/check-changes.yml |
Adds permissions, outputs change-file list, rejects pr: overrides, and posts/upserts a PR status comment. |
.changes/README.md |
Documents pr: as maintainer-only; should also document new author: support. |
.changes/visual-ledc-drivers.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
.changes/keepalive-timeout-reconnect.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
.changes/frontend-svelte5.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
.changes/cleanup-function-names.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
.changes/captive-portal-wizard.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
.changes/bug-fixes.md |
Adds pr: frontmatter (currently conflicts with new CI rule). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.