Add alternative hostname and service name helpers - #9
Open
devgianlu wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@alexpevzner Any chance for this to get merged? These helpers are quite important for implementing service name conflict resolution. |
Member
Yes — sorry for not spotting this earlier. To get this merged, we'll need proper function comments that explain what each function does, not just what it calls. One of the core values of this project is providing clear, usable documentation for Avahi's API, since the native documentation is often opaque and incomplete. So simply stating that AlternativeHostname calls avahi_alternative_host_name won't be enough — we need to explain the semantics: what the function actually does, why you'd use it, and what the expected behavior is. Could you add that? Happy to review once it's in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.