Skip to content

Add alternative hostname and service name helpers - #9

Open
devgianlu wants to merge 1 commit into
OpenPrinting:masterfrom
devgianlu:alternative
Open

Add alternative hostname and service name helpers#9
devgianlu wants to merge 1 commit into
OpenPrinting:masterfrom
devgianlu:alternative

Conversation

@devgianlu

Copy link
Copy Markdown
Contributor

No description provided.

@devgianlu

Copy link
Copy Markdown
Contributor Author

@alexpevzner Any chance for this to get merged? These helpers are quite important for implementing service name conflict resolution.

@alexpevzner

Copy link
Copy Markdown
Member

Any chance for this to get merged?

Yes — sorry for not spotting this earlier.

To get this merged, we'll need proper function comments that explain what each function does, not just what it calls.

One of the core values of this project is providing clear, usable documentation for Avahi's API, since the native documentation is often opaque and incomplete. So simply stating that AlternativeHostname calls avahi_alternative_host_name won't be enough — we need to explain the semantics: what the function actually does, why you'd use it, and what the expected behavior is.

Could you add that? Happy to review once it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants