Repository navigation
Fix master - #239
Merged
Merged
Fix master#239
Conversation
`c_example` and `dsimple_test` are the only MUMPS targets that need the
complete MPI symbol set, and nothing uses them. They fail to link on
el10:
undefined reference to `mpi_wtime_'
undefined reference to `dmumps_ana_driver_'
Drop them from `all` here rather than in the MUMPS CMakeLists, so that
the fix survives moo becoming a submodule.
Assisted-by: Claude Opus 5 (1M context)
#237 turned the vendored ColPack/ into a submodule at the same path. A checkout that goes back to a commit with the vendored files then fails: the submodule's work tree stays behind as untracked files, and git will not overwrite them error: The following untracked working tree files would be overwritten by checkout: ColPack/.gitignore Jenkins' `git clean -fdx` leaves it alone (it is a nested repository), so one build of a PR on the new 3rdParty broke every later build on that agent of a PR still on the old one. The submodule keeps its name, so an existing clone reuses .git/modules/ColPack. Not `colpack`: on the macOS and Windows file systems that is still the same directory. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Purpose
Approach