fix: replace proprietary hi3516ev200_isp.ko with open_isp#1979
Merged
widgetii merged 1 commit intoOpenIPC:masterfrom Apr 4, 2026
Merged
fix: replace proprietary hi3516ev200_isp.ko with open_isp#1979widgetii merged 1 commit intoOpenIPC:masterfrom
widgetii merged 1 commit intoOpenIPC:masterfrom
Conversation
Remove the last proprietary kernel module for HiSilicon hi3516ev200 family. The open-source open_isp.ko from openhisilicon now works after fixing VI_MAX_VIR_PIPE_NUM mismatch (OpenIPC/openhisilicon#31). Changes: - hisilicon-opensdk.mk: remove DISABLE_ISP=1 for hi3516ev200 - load_hisilicon: replace hi3516ev200_isp with open_isp (4 references) - hisilicon-osdrv-hi3516ev200.mk: stop installing vendor ISP blob - Remove hi3516ev200_isp.ko binary blob (199KB) Depends on: OpenIPC/openhisilicon#31 (VI_MAX_VIR_PIPE_NUM fix) Tested on hi3516ev300 with IMX335 sensor — Majestic starts and produces video with the open-source ISP module. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
widgetii
force-pushed
the
fix/hi3516ev200-open-isp
branch
from
daff450 to
6b303f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DISABLE_ISP=1for hi3516ev200 in hisilicon-opensdk.mkload_hisiliconscript to useopen_ispinstead ofhi3516ev200_isphi3516ev200_isp.koblob (199KB)This eliminates the last proprietary kernel module for the HiSilicon hi3516ev200 family, unblocking migration to modern kernels.
Root cause of original DISABLE_ISP=1
The Goke SDK defines
VI_MAX_VIR_PIPE_NUM=2while HiSilicon SDK defines it as0. This changesVI_MAX_PIPE_NUM(4 vs 2), affecting struct sizes in ioctl interfaces. The vendorlibisp.soand the opensdkopen_isp.koencoded different struct sizes into ioctl numbers, causing all ISP ioctls to fail with0xFFFFFFFF.Fixed in OpenIPC/openhisilicon#31 — this PR depends on that fix being merged first.
Test plan
🤖 Generated with Claude Code