Various bug fixes for AeroDyn when modeling MHK turbines#3278
Merged
andrew-platt merged 4 commits intoOpenFAST:rc-5.0.1from Mar 25, 2026
Merged
Various bug fixes for AeroDyn when modeling MHK turbines#3278andrew-platt merged 4 commits intoOpenFAST:rc-5.0.1from
andrew-platt merged 4 commits intoOpenFAST:rc-5.0.1from
Conversation
* Previously, olaf wake propagation did not consider wave velocity. * A similar bug was found in the SetSectAvgInflow subroutine. * The optional BoxExceedAllow flag for IfW_FlowField_GetVelAcc was not passed correctly through the SeaState WaveField subroutine for AD.
luwang00
added
Type: Bug
Module: AeroDyn
Feature: MHK
andrew-platt
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR fixed several bugs in AD relevant to MHK turbines:
SetSectAvgInflowsubroutine for BEMT.BoxExceedAllowflag forIfW_FlowField_GetVelAccwas not correctly passed through the SeaStateWaveField_GetWaveVelAcc_ADsubroutine.This PR also removed a redundant r-test
ad_MHK_RM1_Fixed_IfWat the request of @hkross.Impacted areas of the software
AeroDyn, SeaState, r-test
Test results, if applicable