Create DreamRefManager#2535
Merged
wixoaGit merged 4 commits intoOpenDreamProject:masterfrom Mar 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved all the
ref()andlocate()helpers to a newDreamRefManager, which holds collections of every DreamObject with its ownRefType. This gets rid of a fair amount of code duplication, makes new ref types easier to create, and moves some code to a place that makes more sense.Fixes #2530, which hopefully fixes the routine Paradise server crashes. This is also an important step in moving towards having our own garbage collector/optimizing DreamValue since every datum would need to get assigned an ID.