Skip to content

OpenConceptLab/ocl_issues#2878 | Align the pt-BR glossary and link the localization guide - #128

Open
filiperochalopes wants to merge 2 commits into
mainfrom
fix/pt-br-glossary-2878
Open

filiperochalopes wants to merge 2 commits into
mainfrom
fix/pt-br-glossary-2878

Conversation

@filiperochalopes

@filiperochalopes filiperochalopes commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: Aligns the remaining pt-BR strings with the canonical OCL glossary (sentence case for Concept Class / Datatype, "Code System Bridge" as a proper name, "mapeamento" in the retrieve-candidates helper) and links src/i18n to the OCL Design System localization guide. Refs OpenConceptLab/ocl_issues#2878 (the design-system guide itself lives in another repo, so this PR does not close the issue).

Base: origin/main at 1505d41 (1.0.48-beta), merged into the branch in 1224701. Most of the branch's earlier glossary commits already reached main (oclmap#90 and later pt-BR work) or were superseded by it, so the net diff is small.


Main Changes

Area Files Description
pt-BR catalog src/i18n/locales/pt-BR/translations.json (+5/-5) Five string fixes, listed below
i18n docs src/i18n/README.md (+8/-0) New short README that points to the OCL Design System localization guide and states the key/placeholder/tag preservation rules
Key Before (main) After
concept.concept_class Classe do Conceito Classe do conceito
concept.datatype Tipo de Dado Tipo de dado
map_project.retrieve_candidates_helper_text …algoritmos de correspondência: …algoritmos de mapeamento:
map_project.bridge_canonical_url_description …code system bridge… …Code System Bridge…
map_project.algo_canonical_url_description …code system no qual… …Code System no qual…

Merge conflict resolution

The branch was cut from an old main; src/i18n/locales/pt-BR/translations.json conflicted with origin/main (24 keys changed on both sides). Resolved per JSON key with a three-way merge (base = 25e2f8a), not by hand-editing hunks:

Case Keys Choice Rationale
main deleted the key 14 (e.g. retired_concepts, include_retired, period_one_time) Deleted main removed unreferenced keys in ocl_issues#2917; keeping them would resurrect unused strings and fail the catalog test
"Auto Match" vs "AutoMatch" 4 (auto_match, auto_match_rows_failed, quota…auto_match ×2) main (AutoMatch) The product name was set to "AutoMatch" in every language by ocl_issues#2885
Newer wording on main 6 (input_language_helper, field_configuration_description with <0> tag, bridge_version_description/unavailable/reset, quota.consequence.generic) main Same intent, more recent and complete (keeps the link tag and the "OCL AI Assistant" naming)

Keys changed on only one side keep that side's value, so nothing from main was lost.


Key Decisions

Decision Choice Rationale
Which side wins a both-sides-changed key main Its text is newer and already reviewed; glossary intent is the same
Closes vs Refs Refs ocl_issues#2878 also asks for the design-system guide, which is not in this repo
Retrieve-candidates wording "mapeamento" Matches bridge_version_description and field_configuration_description on main

Verification Checklist

npm test          # node --test 'src/**/__tests__/**/*.test.js'
git diff --numstat origin/main...HEAD
  • npm test: 656 tests, 656 pass, 0 fail (includes src/i18n/__tests__/catalogKeys.test.js and aiAssistantNaming.test.js), run on the merged tree 1224701
  • No conflict markers left; pt-BR/translations.json parses as JSON
  • git diff --numstat origin/main...HEAD lists only the two files above
  • Design-system guide URL linked from src/i18n/README.md answers HTTP 200
  • npm run build not run
  • Visual check of the pt-BR UI (Concept page, Retrieve Candidates dialog, Bridge/algorithm settings) not done
  • gh pr view <n> --json mergeable,closingIssuesReferences after the PR is opened

* Add guidance to follow the OCL Design System localization guide and preserve translation keys and placeholders

* Update Portuguese terminology for retired content, locales, mapping algorithms, Bridge concepts, and quota messages
…conflicts

* Resolve the pt-BR catalog conflicts per key: keys that main removed as unused stay removed, and main's AutoMatch naming and newer wording win

* Keep the branch's glossary fixes on keys main did not touch, such as sentence case for concept class and datatype and mapeamento in the retrieve candidates helper
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T15:06:30.344918Z 1224701 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant