Repository navigation
OpenConceptLab/ocl_issues#2878 | Align the pt-BR glossary and link the localization guide - #128
Open
filiperochalopes wants to merge 2 commits into
Open
filiperochalopes wants to merge 2 commits into
filiperochalopes wants to merge 2 commits into
Conversation
* Add guidance to follow the OCL Design System localization guide and preserve translation keys and placeholders * Update Portuguese terminology for retired content, locales, mapping algorithms, Bridge concepts, and quota messages
…conflicts * Resolve the pt-BR catalog conflicts per key: keys that main removed as unused stay removed, and main's AutoMatch naming and newer wording win * Keep the branch's glossary fixes on keys main did not touch, such as sentence case for concept class and datatype and mapeamento in the retrieve candidates helper
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Aligns the remaining pt-BR strings with the canonical OCL glossary (sentence case for Concept Class / Datatype, "Code System Bridge" as a proper name, "mapeamento" in the retrieve-candidates helper) and links
src/i18nto the OCL Design System localization guide. Refs OpenConceptLab/ocl_issues#2878 (the design-system guide itself lives in another repo, so this PR does not close the issue).Base:
origin/mainat1505d41(1.0.48-beta), merged into the branch in1224701. Most of the branch's earlier glossary commits already reachedmain(oclmap#90 and later pt-BR work) or were superseded by it, so the net diff is small.Main Changes
src/i18n/locales/pt-BR/translations.json(+5/-5)src/i18n/README.md(+8/-0)main)concept.concept_classconcept.datatypemap_project.retrieve_candidates_helper_textmap_project.bridge_canonical_url_descriptionmap_project.algo_canonical_url_descriptionMerge conflict resolution
The branch was cut from an old
main;src/i18n/locales/pt-BR/translations.jsonconflicted withorigin/main(24 keys changed on both sides). Resolved per JSON key with a three-way merge (base =25e2f8a), not by hand-editing hunks:maindeleted the keyretired_concepts,include_retired,period_one_time)mainremoved unreferenced keys in ocl_issues#2917; keeping them would resurrect unused strings and fail the catalog testauto_match,auto_match_rows_failed,quota…auto_match×2)main(AutoMatch)maininput_language_helper,field_configuration_descriptionwith<0>tag,bridge_version_description/unavailable/reset,quota.consequence.generic)mainKeys changed on only one side keep that side's value, so nothing from
mainwas lost.Key Decisions
mainClosesvsRefsRefsbridge_version_descriptionandfield_configuration_descriptiononmainVerification Checklist
npm test: 656 tests, 656 pass, 0 fail (includessrc/i18n/__tests__/catalogKeys.test.jsandaiAssistantNaming.test.js), run on the merged tree1224701pt-BR/translations.jsonparses as JSONgit diff --numstat origin/main...HEADlists only the two files abovesrc/i18n/README.mdanswers HTTP 200npm run buildnot rungh pr view <n> --json mergeable,closingIssuesReferencesafter the PR is opened