Repository navigation
OpenConceptLab/ocl_online#551 | The Mapper handles recommendations from a decision model - #126
Draft
filiperochalopes wants to merge 2 commits into
Draft
filiperochalopes wants to merge 2 commits into
filiperochalopes wants to merge 2 commits into
Conversation
… in the Mapper
A decision model returns no rationale, match_strength or confidence_level, and runs on its own
ai_assistant.decision_calls allowance. The Mapper now copes with that:
- AICandidatesAnalysis: no empty narrative block when there is no narrative.
- Log/Discuss: an analysis without a rationale is logged as "<recommendation> <primary code>", never
"AIRecommendation: undefined" (getAIRecommendationDescription; Discuss also guards older entries).
- Auto Match skip: hasCurrentAnalysis also compares the template key and version, so a chat answer
does not stand in for a decision one (or one version for another). An analysis with no recorded
version, or a run with no known one, is redone.
- Default template: a project that names none runs the chat default, or the decision default
(PROMPTS_DECISION_KEY_DEFAULT) for a user entitled to decision calls but not generative ones.
Entitlement is still enforced by the server; there is no fallback between the two.
- ai_assistant_decision_calls_{limit_reached,not_entitled} are AI preview/quota errors and reuse the
existing "OCL AI Assistant calls" meter and copy.
The export needed no change: the rationale, confidence and out-of-scope columns already resolve to null
when absent. Not done: restricting the staff model selector to decision models for a decision template.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The branch was cut from a stale fork main (73 commits behind OpenConceptLab/oclmap main). Conflicts:
- MapProject.jsx: import line; kept both PROMPTS_DECISION_KEY_DEFAULT and applyTemplateColumns.
- previewLimits.test.js: kept both tests (decision-call copy, and upstream's every-refusal-has-a-message).
Follow-ups for upstream changes this branch had not seen:
- limitAction.js (new upstream): map ai_assistant_decision_calls_{limit_reached,not_entitled} to the
ai_assistant.decision_calls capability, as every other refusal is, so the Online plan action can be asked.
- getQuotaError no longer returns usage: drop it from the decision-call expectation.
npm run test: 667 pass, 0 fail. npm run build: compiled successfully.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
3 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Notes —
feature/decision-modelsTL;DR: Makes the Mapper handle recommendations from a decision model (no rationale, no
match_strength, its ownai_assistant.decision_callsallowance). Part of OpenConceptLab/ocl_online#551 (decision models for the AI Assistant's LLM-as-judge); this is the OCL Mapper piece of changes that also land in oclapi2 and ocl-ai-assistant. It is not the whole ticket, so there is no closing keyword.Draft: it depends on the AI Assistant and oclapi2 pieces below, and no decision template exists yet on any environment.
Related PRs
ai_assistant.decision_callscapability(action_type, inference_type)Main Changes
Counts from the PR's own file list on GitHub (13 files, +149/−19), against
OpenConceptLab/oclmapmain.map-projects/AICandidatesAnalysis.jsx(+4/-0)map-projects/aiVisibility.js(+24),map-projects/MapProject.jsx(+16/-13),map-projects/Discuss.jsx(+4/-2)<recommendation> <primary code>, never "AIRecommendation: undefined". Discuss also guards older entries saved with no descriptionmap-projects/autoMatchRows.js(+13/-2),map-projects/MapProject.jsxhasCurrentAnalysisalso compares the templatekeyandversion. Two call sites pass the run's templatemap-projects/aiVisibility.js,map-projects/constants.jsx(+3),map-projects/MapProject.jsxPROMPTS_DECISION_KEY_DEFAULTfor a user entitled to decision calls and not generative onescommon/quotaErrors.js(+2),common/limitAction.js(+2),map-projects/previewLimits.js(+6)ai_assistant_decision_calls_{limit_reached,not_entitled}are AI preview / quota errors and reuse the existing "OCL AI Assistant calls" meter and copy (no new strings in the 4 locales).limitAction.jsnames theai_assistant.decision_callscapability, like every other refusal, when asking the Online service for a plan actionaiVisibility.test.js(+35/-1),autoMatchRows.test.js(+26),previewLimits.test.js(+9),quotaErrors.test.js(+5/-1)aiVisibilitydid not even load), then greenNo change needed: the export.
__oclai_rationale__,__oclai_confidence_score__and__oclai_oos_suggestions__already resolve tonullwhen the field is absent, and the title only appendsmatch_strengthwhen it exists.What a decision answer looks like in the log
{rationale: 'because'}(generative)because(unchanged){recommendation: 'RECOMMEND', primary_candidate: {canonical_reference: {code: 'E11.9'}}}(decision)RECOMMEND E11.9{recommendation: 'REJECT'}REJECT{}AIRecommendationKey Decisions
key+version-1(kill switch) counts as not entitledPROMPTS_DECISION_KEY_DEFAULTmatch-recommend-decisionVerification Checklist
npm run test NODE_ENV=development API_URL=http://localhost:8000 npm run buildnpm run test: 667 tests, 667 pass, 0 fail (after merging upstreammain; 577/577 before the merge)npm run build:webpack compiled successfully.jsxfiles changed parse (Babel,jsxplugin):AICandidatesAnalysis,Discuss,MapProject,constantsdecisiontemplate)limitAction.jsasks the Online service aboutai_assistant.decision_calls; not checked whetherocl_online's/billing/plan/knows that capability (an unknown one would simply show no action)rationalestays the same after save and reloadHeads-up for review
ocl_issues#2908, open,CONFLICTINGwithmainon its own) edits the same files:autoMatchRows.jsright aroundhasCurrentAnalysis, plusDiscuss.jsxandMapProject.jsx. This branch merges cleanly with the currentmain(it already contains a merge of it), so whichever of the two lands second needs to reconcilehasCurrentAnalysis.ai_assistant.decision_callsingroups.yaml.