Skip to content

OpenConceptLab/ocl_issues#2986 | Keep the Mapper project header on one row at narrow widths - #125

Merged
snyaggarwal merged 3 commits into
mainfrom
issues#2986
Nov 2, 2026
Merged

snyaggarwal merged 3 commits into
mainfrom
issues#2986

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

Fixes OpenConceptLab/ocl_issues#2986

  • AutoMatch moves into the Controls toolbar with three states: full, icon-only with tooltip, and in the ⋮ menu
  • Save can move into the ⋮ menu when space runs out
  • The toolbar no longer wraps and "last saved …" stays on one line
  • The project name fills the available space, truncates with an ellipsis and shows in full on hover

🤖 Generated with Claude Code

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: changes requested

Issue complete: not yet. The action ordering and overflow behavior look sound, but the width budget can still leave the header wider than its container in a normal processing state.

Findings:

  • P2: measure the actual space left for the toolbar instead of subtracting a fixed reservation.

P1/P3–P5 findings: none.
Nitpicks: none.
Security blockers: none.

Validation: the full local test suite passes (653 tests), ESLint passes, and the current GitHub lint/test and Snyk checks pass.

…r the toolbar budget instead of a fixed reservation
@snyaggarwal snyaggarwal assigned paynejd and snyaggarwal and unassigned paynejd Nov 2, 2026
@snyaggarwal
snyaggarwal requested a review from paynejd November 2, 2026 12:31

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review verdict: changes requested

The prior fixed-reservation finding is addressed, but the measured-width path exposes one remaining P2: a finite zero/negative toolbar budget selects the largest layout instead of the smallest one.

P1/P3–P5 findings: none.
Nitpicks: none.
Security blockers: none.

Validation: the full local test suite passes (653 tests), ESLint passes, and the updated GitHub lint/test and Snyk checks pass.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review verdict: LGTM

Both prior P2 findings are addressed. The measured toolbar budget now handles finite zero/negative values by choosing the narrowest state, with direct regression coverage.

P1–P5 findings: none.
Nitpicks: none.
Security blockers: none.

Validation: the full local test suite passes (654 tests), ESLint passes, and the updated GitHub lint/test and Snyk checks pass.

@snyaggarwal
snyaggarwal merged commit f2df395 into main Nov 2, 2026
2 checks passed
@snyaggarwal
snyaggarwal deleted the issues#2986 branch November 2, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mapper: the project header wraps in narrower windows

2 participants