Repository navigation
OpenConceptLab/ocl_issues#2986 | Keep the Mapper project header on one row at narrow widths - #125
Conversation
…e row at narrow widths
snyaggarwal
left a comment
There was a problem hiding this comment.
Verdict: changes requested
Issue complete: not yet. The action ordering and overflow behavior look sound, but the width budget can still leave the header wider than its container in a normal processing state.
Findings:
- P2: measure the actual space left for the toolbar instead of subtracting a fixed reservation.
P1/P3–P5 findings: none.
Nitpicks: none.
Security blockers: none.
Validation: the full local test suite passes (653 tests), ESLint passes, and the current GitHub lint/test and Snyk checks pass.
…r the toolbar budget instead of a fixed reservation
snyaggarwal
left a comment
There was a problem hiding this comment.
Re-review verdict: changes requested
The prior fixed-reservation finding is addressed, but the measured-width path exposes one remaining P2: a finite zero/negative toolbar budget selects the largest layout instead of the smallest one.
P1/P3–P5 findings: none.
Nitpicks: none.
Security blockers: none.
Validation: the full local test suite passes (653 tests), ESLint passes, and the updated GitHub lint/test and Snyk checks pass.
…measured budget is zero or negative
snyaggarwal
left a comment
There was a problem hiding this comment.
Re-review verdict: LGTM
Both prior P2 findings are addressed. The measured toolbar budget now handles finite zero/negative values by choosing the narrowest state, with direct regression coverage.
P1–P5 findings: none.
Nitpicks: none.
Security blockers: none.
Validation: the full local test suite passes (654 tests), ESLint passes, and the updated GitHub lint/test and Snyk checks pass.
Fixes OpenConceptLab/ocl_issues#2986
Controlstoolbar with three states: full, icon-only with tooltip, and in the ⋮ menu🤖 Generated with Claude Code