Repository navigation
OpenConceptLab/ocl_issues#2985 | Project breadcrumb uses OwnerButton and the design system's breadcrumb pieces - #123
Conversation
…and the design system's breadcrumb pieces
snyaggarwal
left a comment
There was a problem hiding this comment.
One review pass, P1–P5 considered.
Findings:
-
[P2] The issue is not complete: the third acceptance criterion requires the Mapping Projects breadcrumb piece to be added to the ocl-design-system Breadcrumbs page when the shared component lacks it. This PR builds the piece locally and explicitly leaves that work out, while closing OpenConceptLab/ocl_issues#2985. Please add the design-system update (or link the replacement that already satisfies the criterion) before this closes the issue.
-
[P3] Standalone owner rendering now exposes a broken button/tooltip: in
MapProjectBreadcrumb.jsx,ownerURLis undefined when no TermBrowser is configured, butOwnerButtonstill renders a button wrapped inOwnerTooltip. The button has no action, and for users the tooltip receives{id: owner}whileUserTooltiprendersusername, producing an empty/skeleton tooltip. The previous standalone crumb was plain text. Suppress the tooltip/non-action affordance in this branch (for example withnoTooltip={!ownerCrumb.href}and the appropriate non-link rendering), or otherwise supply a usable standalone owner target.
Checks: full test suite passes (650/650); focused ESLint passes. No P1, P4, or P5 findings. GitHub does not allow a request-changes verdict on one’s own PR, so this is posted as a review comment.
(snyaggarwal • Codex review)
|
Addressed the review:
|
…en no TermBrowser is configured
snyaggarwal
left a comment
There was a problem hiding this comment.
Re-review of 05c66ef (P1–P5 considered).
The tooltip half of the previous P3 is fixed, but two findings remain:
-
[P2] The design-system acceptance criterion is still incomplete. The PR still changes only
oclmap, while OpenConceptLab/ocl_issues#2985 requires the new Mapping Projects breadcrumb piece to be added to the ocl-design-system Breadcrumbs page when the shared component lacks it. Please add/link that update before this PR closes the issue. -
[P3] The standalone owner is still a focusable button with no action. Passing
component: "span"throughOwnerButtonchanges the host element, but MUIButtonBasegives a non-native hostrole="button",tabIndex=0, and synthetic keyboard activation. Consequently keyboard and screen-reader users still encounter a button that does nothing, despite the cursor and ripple changes. Render a genuinely non-interactive owner (or extend the shared component with a true plain mode) rather than changing only the Button host. A render-level assertion for the standalone branch would catch this.
Checks: full suite passes (650/650); focused ESLint passes; diff check passes. No new P1, P4, or P5 findings.
(snyaggarwal • Codex re-review)
… text, not a button
|
Re-review addressed in the latest commit:
|
…ng Projects link
Refs OpenConceptLab/ocl_issues#2985
The project header breadcrumb now shows the owner as an
OwnerButton(user or org icon plus name, shortened), a dot separator, then Mapping Projects. Link targets are unchanged. Without a TermBrowser the owner has no link and no tooltip.Not included: adding the Mapping Projects segment to ocl-design-system's Breadcrumbs page (third acceptance criterion), so this does not close the issue.
🤖 Generated with Claude Code