Skip to content

OpenConceptLab/ocl_issues#2985 | Project breadcrumb uses OwnerButton and the design system's breadcrumb pieces - #123

Merged
snyaggarwal merged 4 commits into
mainfrom
issues#2985
Nov 2, 2026
Merged

snyaggarwal merged 4 commits into
mainfrom
issues#2985

Conversation

@snyaggarwal

@snyaggarwal snyaggarwal commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Refs OpenConceptLab/ocl_issues#2985

The project header breadcrumb now shows the owner as an OwnerButton (user or org icon plus name, shortened), a dot separator, then Mapping Projects. Link targets are unchanged. Without a TermBrowser the owner has no link and no tooltip.

Not included: adding the Mapping Projects segment to ocl-design-system's Breadcrumbs page (third acceptance criterion), so this does not close the issue.

🤖 Generated with Claude Code

@snyaggarwal snyaggarwal self-assigned this Nov 2, 2026

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One review pass, P1–P5 considered.

Findings:

  1. [P2] The issue is not complete: the third acceptance criterion requires the Mapping Projects breadcrumb piece to be added to the ocl-design-system Breadcrumbs page when the shared component lacks it. This PR builds the piece locally and explicitly leaves that work out, while closing OpenConceptLab/ocl_issues#2985. Please add the design-system update (or link the replacement that already satisfies the criterion) before this closes the issue.

  2. [P3] Standalone owner rendering now exposes a broken button/tooltip: in MapProjectBreadcrumb.jsx, ownerURL is undefined when no TermBrowser is configured, but OwnerButton still renders a button wrapped in OwnerTooltip. The button has no action, and for users the tooltip receives {id: owner} while UserTooltip renders username, producing an empty/skeleton tooltip. The previous standalone crumb was plain text. Suppress the tooltip/non-action affordance in this branch (for example with noTooltip={!ownerCrumb.href} and the appropriate non-link rendering), or otherwise supply a usable standalone owner target.

Checks: full test suite passes (650/650); focused ESLint passes. No P1, P4, or P5 findings. GitHub does not allow a request-changes verdict on one’s own PR, so this is posted as a review comment.

(snyaggarwal • Codex review)

@snyaggarwal

Copy link
Copy Markdown
Contributor Author

Addressed the review:

  • P3: with no TermBrowser configured, the owner now renders as non-interactive text with its icon, with no tooltip and no pointer affordance. With a TermBrowser it is unchanged.
  • P2: the design-system docs addition is a separate change in ocl-design-system, still to do. I changed the PR to Refs so merging it does not close the issue early.

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of 05c66ef (P1–P5 considered).

The tooltip half of the previous P3 is fixed, but two findings remain:

  1. [P2] The design-system acceptance criterion is still incomplete. The PR still changes only oclmap, while OpenConceptLab/ocl_issues#2985 requires the new Mapping Projects breadcrumb piece to be added to the ocl-design-system Breadcrumbs page when the shared component lacks it. Please add/link that update before this PR closes the issue.

  2. [P3] The standalone owner is still a focusable button with no action. Passing component: "span" through OwnerButton changes the host element, but MUI ButtonBase gives a non-native host role="button", tabIndex=0, and synthetic keyboard activation. Consequently keyboard and screen-reader users still encounter a button that does nothing, despite the cursor and ripple changes. Render a genuinely non-interactive owner (or extend the shared component with a true plain mode) rather than changing only the Button host. A render-level assertion for the standalone branch would catch this.

Checks: full suite passes (650/650); focused ESLint passes; diff check passes. No new P1, P4, or P5 findings.

(snyaggarwal • Codex re-review)

@snyaggarwal

Copy link
Copy Markdown
Contributor Author

Re-review addressed in the latest commit:

  • P3: without a TermBrowser the owner is now a plain span (icon plus name), not a MUI Button, so there is no role=button, tab stop or keyboard activation. With a TermBrowser it is still an OwnerButton link.
  • P2: unchanged. The design-system update is a separate change in ocl-design-system, and this PR uses Refs so it does not close the issue.

@snyaggarwal
snyaggarwal merged commit d75e59b into main Nov 2, 2026
2 checks passed
@snyaggarwal
snyaggarwal deleted the issues#2985 branch November 2, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant