Conversation
mssssss123
self-requested a review
September 11, 2026 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari can close the model picker without changing the selected model: clicking a model name blurs the auto-focused search input, and the container's
onBlurunmounts the menu before the button receivesclick. Opening advanced settings and changing temperature works around this because those controls already preserve focus or update the selection through a different event.Prevent the model-name button's default mouse-down focus action, matching the existing advanced-settings and permission buttons. Keep the selection in
onClickso keyboard activation still works.Add eight component regressions covering Safari-style mouse focus, filtered selection, Auto, conventional button focus, keyboard click activation, advanced parameter preservation, and closing when focus leaves the menu. The tests render the real
ComposerV2; jsdom's missing native mouse-focus behavior is simulated explicitly.Related to #565; this change addresses the reproducible Safari model-option click failure.
Validation
pnpm --dir ui exec vitest run src/components/chat-v2/ComposerV2.modelSelection.test.tsx src/components/chat/hooks/useChatModelSelection.test.tsx src/components/chat-v2/modelCapabilityOptions.spec.tsComposerV2.tsxretains three pre-existing warnings.