Skip to content

fix(typescript-nestjs-server): import generic return types#24005

Open
zonradkuse wants to merge 1 commit into
OpenAPITools:masterfrom
zonradkuse:fix/typescript-nestjs-server-array-return-type-generics
Open

fix(typescript-nestjs-server): import generic return types#24005
zonradkuse wants to merge 1 commit into
OpenAPITools:masterfrom
zonradkuse:fix/typescript-nestjs-server-array-return-type-generics

Conversation

@zonradkuse

@zonradkuse zonradkuse commented Jun 11, 2026

Copy link
Copy Markdown

We observed that Array return types would be missing their corresponding import in the controller and the api. The cause is a typo in the typescript-nestjs-server generator that checked if a full Array type needed importing instead of the generic parameter T to Array<T>.

This PR fixes the behaviour.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. -> @davidgamero @mkusaka @joscha @dennisameling (2026/02) - mentioning the most recent 4 members. Feel free to add more.

Summary by cubic

Fixes missing imports for generic return types in the typescript-nestjs-server generator by importing the generic type (e.g., T in Array) instead of the container type. This ensures controllers and APIs include correct model imports and avoids compile errors.

Written for commit 95e899a. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant