Skip to content

[BUG][TYPESCRIPT-FETCH] Fix #23998: Form data requests with mime type parameters use URLSearchParams instead of FormData #24000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macjohnny merged 2 commits into from
Jun 12, 2026
Merged

[BUG][TYPESCRIPT-FETCH] Fix #23998: Form data requests with mime type parameters use URLSearchParams instead of FormData #24000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adab279
Replace equality check with startsWith call
MarcelKonrad Jun 11, 2026
9a9ca47
Update examples
MarcelKonrad Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-fetch/runtime.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/others/typescript-fetch/additional-properties-in-multipart-issue/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/others/typescript-fetch/infinite-recursion-issue/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/others/typescript-fetch/self-import-issue/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/allOf-nullable/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {

@cubic-dev-ai cubic-dev-ai Bot Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: MIME type detection in canConsumeForm is case-sensitive, which violates RFC 2045/7231 case-insensitivity rules for media types. Mixed-case multipart/form-data values (e.g., Multipart/Form-Data) will incorrectly bypass FormData selection.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/typescript-fetch/builds/allOf-nullable/runtime.ts, line 372:

<comment>MIME type detection in `canConsumeForm` is case-sensitive, which violates RFC 2045/7231 case-insensitivity rules for media types. Mixed-case `multipart/form-data` values (e.g., `Multipart/Form-Data`) will incorrectly bypass FormData selection.</comment>

<file context>
@@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {
 export function canConsumeForm(consumes: Consume[]): boolean {
     for (const consume of consumes) {
-        if ('multipart/form-data' === consume.contentType) {
+        if (consume.contentType?.startsWith('multipart/form-data') == true) {
             return true;
         }
</file context>

return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/allOf-readonly/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/default-v3.0/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/default/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/enum/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/es6-target/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/multiple-parameters/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/oneOf/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/prefix-parameter-interfaces/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/sagas-and-records/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/snakecase-discriminator/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/validation-attributes/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/with-interfaces/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/with-npm-version/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/with-string-enums/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function mapValues(data: any, fn: (item: any) => any) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion samples/client/petstore/typescript-fetch/builds/without-runtime-checks/src/runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ export function exists(json: any, key: string) {

export function canConsumeForm(consumes: Consume[]): boolean {
for (const consume of consumes) {
if ('multipart/form-data' === consume.contentType) {
if (consume.contentType?.startsWith('multipart/form-data') == true) {
return true;
}
}
Expand Down
Loading