Skip to content

fix(kotlin): Redefined Vars of parent are marked inherited.#22219

Open
Sylvain-maillard wants to merge 1 commit into
OpenAPITools:masterfrom
Sylvain-maillard:fix_issue22216-vars-override-missing
Open

fix(kotlin): Redefined Vars of parent are marked inherited.#22219
Sylvain-maillard wants to merge 1 commit into
OpenAPITools:masterfrom
Sylvain-maillard:fix_issue22216-vars-override-missing

Conversation

@Sylvain-maillard

Copy link
Copy Markdown

Redefined vars should be marked as inherited so that override modifier is added on children class.

Changes where done in org.openapitools.codegen.languages.AbstractKotlinCodegen#fromModel by adding redefined vars to the map of vars that will be marked as inherited when the model has a parent.

Validated with a Test in org.openapitools.codegen.kotlin.KotlinClientCodegenModelTest

cc @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) 😊

Closes #22216

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

wing328 commented Oct 28, 2025

Copy link
Copy Markdown
Member

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@e5l e5l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sylvain-maillard

Sylvain-maillard commented Oct 28, 2025

Copy link
Copy Markdown
Author

Hi @wing328 and @e5l , thanks for your remarks, I've changed my email address so it should fix the commit issue...

It seems that there is a problem with the CI with this test : GlobalSettingsTest.testNonStringSystemProperties, but I see that it should be disabled. Should I do something about that test ? (I see that the test is marked @disabled which is a Junit annotation, where the test uses the TestNG framework... maybe this is an issue ?)

@Sylvain-maillard

Copy link
Copy Markdown
Author

Hi @wing328 and @e5l , is there something missing that prevent the PR to be merged ? thanks 😃

@wing328

wing328 commented Dec 17, 2025

Copy link
Copy Markdown
Member

please resolve the merge conflicts when you've time and i'll try to get it merged soon

@Sylvain-maillard Sylvain-maillard force-pushed the fix_issue22216-vars-override-missing branch from e9f6d76 to 8d148d7 Compare December 17, 2025 10:23
@Sylvain-maillard

Copy link
Copy Markdown
Author

@wing328 I fixed the conflicts 😉

@wing328 wing328 modified the milestones: 7.18.0, 7.19.0 Dec 22, 2025
@wing328 wing328 modified the milestones: 7.19.0, 7.20.0 Jan 19, 2026
@wing328 wing328 modified the milestones: 7.20.0, 7.21.0 Feb 16, 2026
@wing328 wing328 modified the milestones: 7.21.0, 7.22.0 Mar 24, 2026
@wing328 wing328 modified the milestones: 7.22.0, 7.23.0 Apr 28, 2026
@syh7

syh7 commented May 26, 2026

Copy link
Copy Markdown

@wing328 @e5l any change of merging this? I am also running into this issue and it's been open for 8 months now

@wing328 wing328 modified the milestones: 7.23.0, 7.24.0 Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Kotlin] overriden variables are not generated with 'override' keyword

4 participants