Skip to content

Support DelayedVector/vector-cube inputs in filter_spatial (including remote read_vector URLs)#500

Draft
Copilot wants to merge 2 commits into
masterfrom
copilot/support-delayedvector-filter-spatial
Draft

Support DelayedVector/vector-cube inputs in filter_spatial (including remote read_vector URLs)#500
Copilot wants to merge 2 commits into
masterfrom
copilot/support-delayedvector-filter-spatial

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

filter_spatial did not reliably support lazy vector inputs produced by read_vector (notably remote URLs), while aggregate_spatial already handled this path. This PR aligns filter_spatial with that behavior and adds coverage for remote URL inputs without file extensions.

  • Behavioral alignment in filter_spatial

    • Switched DelayedVector handling from direct from_fiona(...).to_multipolygon() conversion to DelayedVector.to_driver_vector_cube().
    • This keeps filter_spatial on the same normalization path as aggregate_spatial and preserves vector-cube semantics.
  • Support for remote lazy vectors

    • filter_spatial now accepts DelayedVector values originating from read_vector over HTTP URLs (including extensionless URLs) via the DriverVectorCube conversion path.
  • Regression coverage

    • Added a focused dry-run test for:
      • read_vector(filename=<remote-url-without-extension>)
      • passing that result into filter_spatial
      • asserting geometries are tracked as DriverVectorCube with the expected bounds.
# before
elif isinstance(geometries, DelayedVector):
    geometries = DriverVectorCube.from_fiona([geometries.path]).to_multipolygon()

# after
elif isinstance(geometries, DelayedVector):
    geometries = geometries.to_driver_vector_cube()

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • artifactory.vgt.vito.be
    • Triggering command: /usr/bin/python /usr/bin/python /usr/lib/python3/dist-packages/pip/__pip-REDACTED__.py install --ignore-installed --no-user --prefix /tmp/pip-build-env-fud55wxy/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i REDACTED --extra-index-url REDACTED -- setuptools&gt;=40.8.0 (dns block)
    • Triggering command: /usr/bin/python python -m pip install -e .[dev] --extra-index-url REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI linked an issue May 14, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Add support for DelayedVector in filter_spatial Support DelayedVector/vector-cube inputs in filter_spatial (including remote read_vector URLs) May 14, 2026
Copilot AI requested a review from jdries May 14, 2026 18:02
Copilot finished work on behalf of jdries May 14, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support DelayedVector in filter_spatial

2 participants